Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Upgrade rollup and storybook #182

Merged
merged 3 commits into from
Apr 11, 2024
Merged

common: Upgrade rollup and storybook #182

merged 3 commits into from
Apr 11, 2024

Conversation

thyal
Copy link
Member

@thyal thyal commented Apr 10, 2024

Description

Some house cleaning 🧹

  • Move all rollup related dependencies to the root folder. We use these in media, core and browser-sdk, so makes sense to keep them in the root
  • Upgrade rollup and related dependencies
  • Upgrade storybook and related dependencies. This was done with npx storybook@latest upgrade, which also did some code changes in the storybook files.

Summary:

Related Issue:

Testing

  1. yarn build should succeed
  2. yarn dev should start storybook and it should run without any errors

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Additional Information

Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: db1ff4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thyal thyal requested a review from a team April 10, 2024 11:04
@thyal thyal force-pushed the thomas/move-dependencies branch from 8ed88fd to 32a3fd6 Compare April 10, 2024 11:09
@thyal thyal force-pushed the thomas/move-dependencies branch from 32a3fd6 to db1ff4d Compare April 10, 2024 13:33
Copy link
Contributor

@richtrwhereby richtrwhereby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work hoisting these dev dependencies to the root package.json 👍

All test steps pass as expected 🚀

@thyal thyal merged commit 80ead8d into main Apr 11, 2024
3 checks passed
@thyal thyal deleted the thomas/move-dependencies branch April 11, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants