core: use getTrack().some() to tell if screenshare has audio and use fallback id #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the `MediaStream.getAudioTracks().length > 0` with a `MediaStream.getTrack().some()` function, as some WebRTC implementation does not have `.getAudioTracks()` implemented.
🦋 Changeset detectedLatest commit: 8f6987d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/canary |
|
🚀 The canary release has been published to npm. You can test the release by installing the newly published version: yarn add @whereby.com/core@0.0.0-canary-20240411085142 |
|
/canary |
|
🚀 The canary release has been published to npm. You can test the release by installing the newly published version: yarn add @whereby.com/core@0.0.0-canary-20240411113310 |
nandito
changed the title
We don't really use the `id` field on the screenshare MediaStream, therefore it's `undefined`. Let's use the `pres-` prefixed clientId for remote participants' screenshares and `local-screenshares` for local participant's screenshare in this case, like we do in PWA.
nandito
force-pushed
the
nandor/cob-617-make-screenshare-captions-work
branch
from
d5b72c1 to
8f6987d
Compare
|
/canary |
|
🚀 The canary release has been published to npm. You can test the release by installing the newly published version: yarn add @whereby.com/core@0.0.0-canary-20240411122200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
MediaStream.getAudioTracks().length > 0with aMediaStream.getTrack().some()function, as some WebRTC implementation does not have.getAudioTracks()implemented.idfor screenshares:pres-<clientId>for remote participants andlocal-screensharefor local participant.Related Issue:
Testing
Screenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Additional Information