Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media: wait for sendtransport before producing #190

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

pnts-se-whereby
Copy link
Contributor

Description

Summary:

Wait for send transport before trying to produce a video track
Also move initial sync code outside of async function

Related Issue:

Testing

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Additional Information

@pnts-se-whereby pnts-se-whereby requested a review from a team April 11, 2024 12:47
Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: 2e5da19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@whereby.com/media Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pnts-se-whereby pnts-se-whereby force-pushed the pontusfagerstrom/cob-667-no-video-track branch from a84b007 to 115cd01 Compare April 11, 2024 12:51
@pnts-se-whereby
Copy link
Contributor Author

/canary

Copy link
Contributor

🚀 The canary release has been published to npm.

You can test the release by installing the newly published version:

yarn add @whereby.com/media@0.0.0-canary-20240411125350

@pnts-se-whereby pnts-se-whereby force-pushed the pontusfagerstrom/cob-667-no-video-track branch from 115cd01 to 2e5da19 Compare April 11, 2024 13:21
@pnts-se-whereby
Copy link
Contributor Author

/canary

Copy link
Contributor

🚀 The canary release has been published to npm.

You can test the release by installing the newly published version:

yarn add @whereby.com/media@0.0.0-canary-20240411132524

@pnts-se-whereby pnts-se-whereby merged commit d5ec7f5 into main Apr 12, 2024
3 checks passed
@pnts-se-whereby pnts-se-whereby deleted the pontusfagerstrom/cob-667-no-video-track branch April 12, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants