media: handle sdp errors #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0fa77c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/canary |
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: yarn add @whereby.com/browser-sdk@0.0.0-canary-20241031135851yarn add @whereby.com/core@0.0.0-canary-20241031135851yarn add @whereby.com/media@0.0.0-canary-20241031135851yarn add @whereby.com/react-native-sdk@0.0.0-canary-20241031135851 |
geirbakke
force-pushed
the
geirbakke/handle-sdp-errors
branch
2 times, most recently
from
8e194a7 to
69a1385
Compare
|
/canary |
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: yarn add @whereby.com/browser-sdk@0.0.0-canary-20241031194056yarn add @whereby.com/core@0.0.0-canary-20241031194056yarn add @whereby.com/media@0.0.0-canary-20241031194056yarn add @whereby.com/react-native-sdk@0.0.0-canary-20241031194056 |
|
/canary |
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: yarn add @whereby.com/browser-sdk@0.0.0-canary-20241101120009yarn add @whereby.com/core@0.0.0-canary-20241101120009yarn add @whereby.com/media@0.0.0-canary-20241101120009yarn add @whereby.com/react-native-sdk@0.0.0-canary-20241101120009 |
geirbakke
force-pushed
the
geirbakke/handle-sdp-errors
branch
from
e499535 to
0fa77c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to clean sdp before setLocalDescription, hopefully working around browser bugs like:
https://issues.webrtc.org/issues/41480892
(and a similar one on Firefox)
It adds events so we can track these kind of errors in our apps
It removes the pendingOffer logic as that was a workaround for a bug long time ago, and interfered with the tracking/events, and makes sure the offer isn't sent to remote end before working locally.
Testing instructions in PWA PR