Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add breakoutGroup to all screenshare objects #481

Conversation

richtrwhereby
Copy link
Contributor

@richtrwhereby richtrwhereby commented Nov 21, 2024

Description

Add a breakoutGroup parameter to the Screenshare interface and set this property when selectScreenshares is accessed.

Related Issue:
#471 (Attach breakoutGroup to all remote and local participants on room_joined, new_client and breakout_group_joined signal events)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

@richtrwhereby richtrwhereby requested a review from thyal November 21, 2024 13:36
Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 34c8ba4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@whereby.com/core Minor
@whereby.com/browser-sdk Patch
@whereby.com/react-native-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@richtrwhereby richtrwhereby merged commit c01569a into main Nov 21, 2024
3 checks passed
@richtrwhereby richtrwhereby deleted the richardtibbett/pan-1488-add-breakgroup-to-screenshare-objects branch November 21, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants