Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser-sdk: Auto mute video cell of local participant in video grid #482

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

thyal
Copy link
Member

@thyal thyal commented Nov 21, 2024

Description

Currently we don't auto-mute the video view of the local participant in the videogrid, which will cause echo when using the default grid. An oversight that wasn't caught because the storybook for the video grid had audio: false in the local media options for the room connection, meaning we never got the echo issues there..

Summary:

Related Issue:

Testing

  1. Go to Video Grid story
  2. Verify that there's no echo

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Additional Information

Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: ad21973

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@whereby.com/browser-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thyal thyal requested a review from a team November 21, 2024 16:05
Copy link
Contributor

@richtrwhereby richtrwhereby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 🚀

@thyal thyal merged commit 43b1b6b into main Nov 22, 2024
3 checks passed
@thyal thyal deleted the thomas/PAN-1519-grid-auto-mute-local-video-cell branch November 22, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants