Add support Rails 6.0 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladislavSokov
force-pushed
the
support-rails-6.0
branch
from
e1507c2 to
fe89760
Compare
ka8725
reviewed
Jun 14, 2024
test/dummy_app/config/environment.rb
Outdated
| @@ -0,0 +1,2 @@ | |||
| ENV['PRIMARY_MIGRATIONS_PATH'] = Rails.root.join('db', 'migrate').to_s | |||
There was a problem hiding this comment.
Env vars usually are defined using shell scripts, or system. Since the runtime got the the Ruby code we should define Ruby vars instead. In other words, Ruby doesn't own env vars, so it should not mutate them or define new ones.
VladislavSokov
force-pushed
the
support-rails-6.0
branch
from
44766d5 to
c710dba
Compare
ka8725
reviewed
Jun 14, 2024
test/dummy_app/config/database.yml
Outdated
| adapter: sqlite3 | ||
| database: tmp/secondary.sqlite3 | ||
| migrations_paths: | ||
| - <%= ENV['SECONDARY_MIGRATIONS_PATH'] %> |
ka8725
approved these changes
Jun 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.