Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated tests for the Glider #25

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Automated tests for the Glider #25

wants to merge 1 commit into from

Conversation

kostysh
Copy link
Contributor

@kostysh kostysh commented Jun 3, 2020

For running tests locally:

export GLIDER_HOST=https://staging.aggregator.windingtree.net
npm run test:newman

@vercel
Copy link

vercel bot commented Jun 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click on the icon next to each commit.

@kostysh kostysh requested a review from mtahon June 3, 2020 11:40
@kostysh kostysh added the enhancement New feature or request label Jun 3, 2020
mtahon
mtahon suggested changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@mtahon mtahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't merge this, there are some clear texts JWT in glider.json which allow to modify the staging environment.

  • Please remove the variable section from the json file and replace by secret environment variables
  • Please clean the git history if possible
    Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtahon mtahon mtahon requested changes

Assignees

@kostysh kostysh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostysh @mtahon @alexey-tashmatov