Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cambridge dictionary #1065

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

howdareyou
Copy link
Contributor

@howdareyou
Copy link
Contributor Author

all resolved. thanks for reviewing.

addon/locale/en-US/addon.ftl Outdated Show resolved Hide resolved
src/modules/services/cambridgedict.ts Outdated Show resolved Hide resolved
@howdareyou
Copy link
Contributor Author

done. sorry for the messy code

@howdareyou
Copy link
Contributor Author

by the way, the page structures of bilingual dictionary are different and difficult to parse, i've only finished the english-to-others part so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants