Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: group dependabot prs and run lint&build for every push&pr #233

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

northword
Copy link
Collaborator

@northword northword commented Dec 30, 2024

closes: #222

  • dependabot: merge all PRs for non-major updates, less intrusive!
  • Run lint/build at push/pr: this is especially useful for pr, to quickly see if contributors' code is compliant with lint requirements, and if dependency changes are clearly breaking the build.

@windingwind
Copy link
Owner

How about adding a no-op test so that other plugins can copy?

@northword
Copy link
Collaborator Author

Recently, I've been working on some Scaffold documentation, so if someone needs it, they should be able to quickly configure it according to the documentation.

We can add a job in the CI file to run the test (comment it), and add the necessary documentation, so that users can use the Action after uncommenting it.

For the test itself, there doesn't seem to be much modification if you don't give the test case file? (except that the test script in package.json is changed to zotero-plugin test)

Also, if it's added, I think it should be added after Scaffold goes to 0.2, not now (since the API/Config may still change).

@windingwind windingwind merged commit 7f062b1 into main Dec 30, 2024
2 checks passed
@northword northword deleted the dependabot-ci branch January 10, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot: Use a single PR to bump all non-major updates
2 participants