feat: [CI-15212]: add ssh passphrase support #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devkimittal
reviewed
Jan 16, 2025
raghavharness
previously approved these changes
Jan 19, 2025
devkimittal
reviewed
Jan 20, 2025
posix/clone
Outdated
|
|
||
| ssh-keyscan -H ${SSH_PORT_FLAG} ${SSH_KEYSCAN_TIMEOUT_FLAG} ${DRONE_NETRC_MACHINE} > ${HOME}/.ssh/known_hosts 2> /dev/null | ||
| export GIT_SSH_COMMAND="ssh -o UserKnownHostsFile=${HOME}/.ssh/known_hosts -i ${HOME}/.ssh/id_rsa ${SSH_PORT_FLAG} -F /dev/null" | ||
| mkdir -p "${HOME}/.ssh" |
There was a problem hiding this comment.
let's not change the indentation?
devkimittal
reviewed
Jan 20, 2025
docker/manifest.rootless.tmpl
Outdated
| @@ -1,4 +1,4 @@ | |||
| image: harness/drone-git:{{#if build.tag}}{{trimPrefix "v" build.tag}}{{else}}latest{{/if}}-rootless | |||
| image: abhayganvir/drone-git:{{#if build.tag}}{{trimPrefix "v" build.tag}}{{else}}latest{{/if}}-rootless | |||
raghavharness
previously approved these changes
Jan 22, 2025
devkimittal
approved these changes
Jan 22, 2025
raghavharness
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ssh passphrase support for linux based git clone steps.
From CI-manager we will pass the SSH Key and SSH_PASSPHRASE to the plugin. Using the given passphrase we will reset the to empty passphrase with given added change. This is been tested for Github, Gitlab, bitbucket and Azure code repository. Below is example test image for Gitlab.
CI-manager changes are associated with this pr: https://app.harness.io/ng/account/vpCkHKsDSxK9_KYfjCTMKA/module/code/orgs/HarnessHCRInternalUAT/projects/Harness_Code/repos/harness-core/pulls/71369