Fix Database Factory for Winter use

[mjauvin]

No description provided.

[mjauvin]

@sephyld how did you manage to use this before this PR?

[mjauvin]

@LukeTowers should I move the HasFactory trait under Database/Traits or Database\Factories\Traits or other ?

[LukeTowers]

What is this used for? Should it be pointing at the winter base model class?

[mjauvin]

Not sure, I copied this from Laravel.

I tried removing it completely and things still work as expected. It's probably only used by the docblock generator.

[LukeTowers]

Should this be returning a Winter BaseFactory, instead of a Laravel one?

[mjauvin]

Yes, if we also change this in Winter repo's create:factory stub.

[mjauvin]

here: modules/system/console/scaffold/factory/factory.stub

[sephyld]

@sephyld how did you manage to use this before this PR?

Hi @mjauvin.

If you are referring to the factory not managing to resolve the model's class name, I just specify the model class using the $model property.

<?php

namespace Winter\Demo\Database\Factories;

use Illuminate\Database\Eloquent\Factories\Factory;
use Winter\Demo\Models\ModelKlass;

/**
 * ModelKlassFactory Factory
 * @extends \Illuminate\Database\Eloquent\Factories\Factory<\Winter\Demo\Models\ModelKlass>
 */
class ModelKlassFactory extends Factory
{

    protected $model = ModelKlass::class;

    /**
     * Define the model's default state.
     *
     * @return array<string, mixed>
     */
    public function definition()
    {
        return [
            // factory definition
        ];
    }
}

In hindsight, I think I should have added it in the PR that took care of the create:factory command. Sorry. If you want, I can take care of it now

[mjauvin]

@sephyld how did you manage to use this before this PR?

If you are referring to the factory not managing to resolve the model's class name, I just specify the model class using the $model property.

Actually, I'm referring to the Model not resolving the Factory. i.e. Model::factory() doesn't work without this PR.

[sephyld]

@sephyld how did you manage to use this before this PR?

If you are referring to the factory not managing to resolve the model's class name, I just specify the model class using the $model property.

Actually, I'm referring to the Model not resolving the Factory. i.e. Model::factory() doesn't work without this PR.

I see. I didn't think about that, I never use the model class to resolve its factory. I only use the factory class directly

[LukeTowers]

@sephyld if you're able to improve the magic in Winter at all that would be much appreciated ❤️