Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added WatchCancellationTokenSource #135

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Added WatchCancellationTokenSource #135

merged 6 commits into from
Nov 8, 2023

Conversation

muratyuceer
Copy link
Contributor

Created in response to this issue

#133 (comment)

@Choc13
Copy link
Collaborator

Choc13 commented Nov 7, 2023

Looks the consul docker images have been moved to hashicorp/consul which is why the integration tests are now failing. Let me raise another PR to fix that and then we can we rebase this one on top of that fix.

@Choc13
Copy link
Collaborator

Choc13 commented Nov 7, 2023

See #136 for the build fix.

@Choc13 Choc13 force-pushed the WatchCancellationTokenSource branch from 4d5f9a0 to 9db55e7 Compare November 8, 2023 15:12
@Choc13 Choc13 merged commit bf77bb3 into wintoncode:master Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Choc13 Choc13 Choc13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muratyuceer @Choc13