Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README with reference to helm repository and publish newest wiremock-0.1.4 version to the repo #31

Closed
wants to merge 1 commit into from
Closed

Update README with reference to helm repository and publish newest wiremock-0.1.4 version to the repo #31

wants to merge 1 commit into from

Conversation

marcules
Copy link

@marcules marcules commented Feb 2, 2024

Hi,

I've seen that, if I try to use this helm-chart with the helm-repo functionality helm repo add wiremock https://wiremock.github.io/helm-charts then the old repository at https://gitkent.github.io/helm-charts is referenced, which returns a 404 when trying to pull the chart from there. Further I've seen that version 0.1.4 was released on github but the index.yaml was not updated - so I've fixed the reference and ran publish-helm-chart.sh to update it.

Kind Regards,
Marc

References

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@marcules marcules requested a review from gitkent as a code owner February 2, 2024 14:12
@gitkent gitkent added the chore Maintenance label Feb 12, 2024
gitkent
gitkent requested changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@gitkent gitkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcules All commits need to be signed. Please sign you commit.

@marcules marcules force-pushed the feature/update-helm-charts-publishing branch from f6aab8a to 2058c13 Compare February 18, 2024 14:51
@marcules
Copy link
Author

@gitkent @oleg-nenashev hi I've amended the commit with my signature now

@marcules marcules requested a review from gitkent February 18, 2024 15:16
gitkent
gitkent requested changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@gitkent gitkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcules This PR has been merged and your PR is now duplicated: #26 and #36. However, we will need your README file change.

The latest chart is now version 0.2.0, so please clean up your PR and test your helm repo add command to see if it is working.

DanielFran added a commit to DanielFran/helm-charts that referenced this pull request Jul 3, 2024
@DanielFran
Changelog:
a6e77e5 
- Update image version and index
- Updated readme with instructions to use helm repository
- Updated notes and readme with port-forward instructions
- Switch to Helm v2
- Substitute WIREMOCK_OPTION by args
- Cleanup _helpers.tpl
- Support additional pod annotations
- Update configmaps
- Update service
- Fix ingress
- Add imagePullSecrets support
- Add service account support
- Add pod and container security context support
- Add horizontal pod autoscaler support
- Updated CI and CD pipelines

Fix wiremock#21
Fix wiremock#22
Fix wiremock#25
Fix wiremock#27
Fix wiremock#28
Fix wiremock#34
Fix wiremock#40
Close wiremock#29
Close wiremock#31
Close wiremock#33
Close wiremock#39
@DanielFran DanielFran mentioned this pull request Jul 3, 2024
Merged
6 tasks
DanielFran added a commit to DanielFran/helm-charts that referenced this pull request Jul 3, 2024
@DanielFran
Changelog:
e061f00 
- Update image version and index
- Update readme with instructions to use helm repository
- Update notes and readme with port-forward instructions
- Switch to Helm v2
- Substitute WIREMOCK_OPTION by args
- Cleanup _helpers.tpl
- Support additional pod annotations
- Update configmaps
- Update service
- Fix ingress
- Add imagePullSecrets support
- Add service account support
- Add pod and container security context support
- Add horizontal pod autoscaler support
- Update CI and CD pipelines

Fix wiremock#21
Fix wiremock#22
Fix wiremock#25
Fix wiremock#27
Fix wiremock#28
Fix wiremock#34
Fix wiremock#40
Close wiremock#29
Close wiremock#31
Close wiremock#33
Close wiremock#39
DanielFran added a commit to DanielFran/helm-charts that referenced this pull request Jul 3, 2024
@DanielFran
Changelog:
e7deadd 
- Update image version and index
- Update readme with instructions to use helm repository
- Update notes and readme with port-forward instructions
- Switch to Helm v2
- Substitute WIREMOCK_OPTION by args
- Cleanup _helpers.tpl
- Support additional pod annotations
- Update configmaps
- Update service
- Fix ingress
- Add imagePullSecrets support
- Add service account support
- Add pod and container security context support
- Add horizontal pod autoscaler support
- Update CI and CD pipelines

Fix wiremock#21
Fix wiremock#22
Fix wiremock#25
Fix wiremock#27
Fix wiremock#28
Fix wiremock#34
Fix wiremock#40
Close wiremock#29
Close wiremock#31
Close wiremock#33
Close wiremock#39
@leeturner leeturner closed this in 53202e1 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitkent gitkent gitkent requested changes

Assignees

@oleg-nenashev oleg-nenashev

Labels
chore Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcules @gitkent @oleg-nenashev