-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add securityContext to copy-responses init container #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Just bumped the chart version that I forgot to do in the previous commit 😞 |
Leave app version as is.
@subigre leave app version as is. For chart version can you please change to Adding a new fields in deployment is a feature. Thanks 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update version to 1.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @subigre can you also please publish the chart with version 1.1.0, otherwise helm install will fail.
Thanks 😊
Hello @gitkent, to be honest, I didn’t understand why the charts are in the |
Done anyway |
@gitkent index has not been updated with the new version 1.1.0 |
@DanielFran thanks for pointing out. Please review this #45 |
It is already up to date in the gh-pages branches Trying to understand, what is the purpose of adding the |
@subigre you are right, chart-releaser action already updated index.yaml gh-pages branch but Github Pages is still pointing at master branch. I have updated Pages to point to gh-pages branch now. Hence no index.yaml and tar ball need to be updated into master branch. We will need to clean this up to avoid confusion. FYI @DanielFran |
This PR adds the missing
securityContext
attribute oncopy-responses
similarly to how it is done onwiremock
andcopy-mappings
containersReferences
Closes #42
Submitter checklist
#help-contributing
or a project-specific channel like#wiremock-java