Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update health check paths #48

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

subigre
Copy link
Contributor

@subigre subigre commented Sep 20, 2024

WireMock has a system endpoint that can be used to return the health status of the server.
It doesn’t change a lot, but I think it makes "a bit more sense" to use this operation for liveness and readiness probes instead of the current /__admin/mappings

https://wiremock.org/docs/standalone/admin-api-reference/#tag/System/operation/getHealth

References

n/a

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

Copy link
Collaborator

@gitkent gitkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for your contribution.

@gitkent gitkent merged commit e4f0a15 into wiremock:master Sep 23, 2024
1 check passed
@subigre subigre deleted the switch-health-endpoint branch September 25, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants