Clean up donation form components #686
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the feature is not used anymore by current banner tests https://phabricator.wikimedia.org/T383984
moiikana
changed the title
- currently only UpgradeToYearlyButtonForm is used by all banners - the FormStep Name can stay at "UpgradeToYearlyForm" as it was detached from the component names https://phabricator.wikimedia.org/T383984
moiikana
force-pushed
the
donationform-cleanup
branch
from
f48a519 to
f89bc10
Compare
- the custom amount form step was not used by any current banner - delete more unused form steps / features https://phabricator.wikimedia.org/T383984
- all of them are not used anymore by current banners https://phabricator.wikimedia.org/T383984
moiikana
force-pushed
the
donationform-cleanup
branch
from
4241d86 to
2598e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T383984