fix cryptoCb cipher macro #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbland1
requested changes
Aug 13, 2024
The point is we aren't guarding it the same as the definition of the struct in |
|
nevermind, I had it wrong, looks good |
jefferyq2
pushed a commit
to jefferyq2/wolfHSM
that referenced
this pull request
Nov 10, 2024
fix cryptoCb cipher macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing macro protection
wolfCrypt guards the definition of wcCryptoInfo->cipher by
#if !defined(NO_AES) || !defined(NO_DES3), but wolfHSM doesn't, resulting in a compile error when using wolfCrypt with no support for those algos (e.g. default wolfBoot)