Improvements to multithread locking and tests. #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
changed the title
dgarske
force-pushed
the
thread_tests
branch
4 times, most recently
from
4bcb429 to
81931da
Compare
embhorn
reviewed
Nov 16, 2023
wolfmqtt/mqtt_client.h
Outdated
| @@ -496,9 +497,8 @@ WOLFMQTT_API int MqttClient_WaitMessage_ex( | |||
| MqttObject *msg, | |||
| int timeout_ms); | |||
|
|
|||
| #if defined(WOLFMQTT_MULTITHREAD) || defined(WOLFMQTT_NONBLOCK) | |||
There was a problem hiding this comment.
Would cancel ever be used outside of non-block or multithread?
embhorn
requested changes
Nov 16, 2023
dgarske
force-pushed
the
thread_tests
branch
from
c04dd10 to
7ed741b
Compare
|
@embhorn let's gets this merged in. I'll followup later with any issues found. |
embhorn
reviewed
Nov 20, 2023
.github/workflows/ubuntu-check.yml
Outdated
| - name: wolfmqtt configure without TLS | ||
| env: | ||
| WOLFMQTT_NO_EXTERNAL_BROKER_TESTS: 1 | ||
| run: ./configure --disable-tls |
There was a problem hiding this comment.
This would be better as --enable-all --disable-tls so that more code paths are enabled
dgarske
force-pushed
the
thread_tests
branch
from
b04ee6a to
ebd7bab
Compare
dgarske
force-pushed
the
thread_tests
branch
from
165c831 to
ac71e60
Compare
…tial writes on all packet types.
…er "exit" in multi-threaded example.
…se. ZD 16769. Remove extra test non-block in `MqttClient_Publish_ReadPayload` (already handled in `MqttSocket_Read`). Cleanup return code 0=success.
…acket type causing the write state to get reset.
…lti-threaded. If not using non-blocking mode consider it "done".
… encounter this between two thread, just not on same thread).
…r multi-thread. Fix for `--disable-tls` and added tests.
…onses expected (Qos 1 and 2).
… works correctly during testing. Customer is seeing a cancel for an ACK become strayed in the pending response list (investigating).
…nt->lastRc used for debugging.
dgarske
force-pushed
the
thread_tests
branch
from
ac71e60 to
e46c2e9
Compare
dgarske
force-pushed
the
thread_tests
branch
from
1152bfd to
da5f198
Compare
…examples are setup to support non-blocking.
|
@embhorn I've sorted out the test issues. This PR is ready to review / merge. |
dgarske
force-pushed
the
thread_tests
branch
from
e5c3605 to
f5b05e4
Compare
embhorn
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MqttClient_Publish_ReadPayload(already handled inMqttSocket_Read).