Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double unlock and double lock in multithread example. #397

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix double unlock and double lock in multithread example. #397

merged 1 commit into from
Mar 7, 2024

Conversation

philljj
Copy link
Contributor

@philljj philljj commented Mar 6, 2024

Description

Fix various thread errors in multithread example.

  • Double unlock of mtLock.
  • Double lock and unlock of pingSignal.
  • Locking on thread 1 and unlocking on thread X of pingSignal.

Testing

  • Tested with --enable-stress and CFLAGS="-DWOLFMQTT_NO_COND_SIGNAL", with valgrind drd and helgrind.
  • Tested with simple thread local storage lock tracker that would print a stack trace and abort on double lock/unlock.

@philljj philljj self-assigned this Mar 6, 2024
@philljj philljj requested a review from embhorn March 7, 2024 14:12
@philljj philljj assigned embhorn and unassigned philljj Mar 7, 2024
@embhorn embhorn merged commit 9bc9856 into wolfSSL:master Mar 7, 2024
12 checks passed
@philljj philljj deleted the fix_double_unlock branch March 14, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embhorn embhorn embhorn approved these changes

Assignees

@embhorn embhorn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philljj @embhorn