Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kn package #40317

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add kn package #40317

wants to merge 3 commits into from

Conversation

kranurag7
Copy link
Member

knative client

this is knative client

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
@kranurag7 kranurag7 marked this pull request as ready for review January 23, 2025 08:14
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Jan 23, 2025
@developer-guy
Copy link
Member

soooo, we are managing multiple versions of knative releases, so, making knative client tool as version streamed would be great if we could do it? I'm curios about what you think? 🙄

@kranurag7
Copy link
Member Author

soooo, we are managing multiple versions of knative releases, so, making knative client tool as version streamed would be great if we could do it? I'm curios about what you think? 🙄

that's a great question, I didn't create version stream for client side tooling given I considered them to a little mature and can work across version especially for commonly used features something like kubectl.
We'll also have to maintain a separate version stream for this for updates because the release cadence for this is different.

This is the main reason to go with latest for now, if you think we should version stream then happy to follow that path. :)

kn.yaml Outdated Show resolved Hide resolved
kn.yaml Outdated
description: Knative CLI implementation
copyright:
- license: Apache-2.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add provides: here for knative=${{package.full-version}} and kn=${{package.full-version}}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a provides for kn but not for knative mostly thinking that in future maybe we'll have a meta knative package someday. 💭

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants