-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kn package #40317
base: main
Are you sure you want to change the base?
add kn package #40317
Conversation
this is knative client Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
soooo, we are managing multiple versions of knative releases, so, making knative client tool as version streamed would be great if we could do it? I'm curios about what you think? 🙄 |
that's a great question, I didn't create version stream for client side tooling given I considered them to a little mature and can work across version especially for commonly used features something like kubectl. This is the main reason to go with latest for now, if you think we should version stream then happy to follow that path. :) |
kn.yaml
Outdated
description: Knative CLI implementation | ||
copyright: | ||
- license: Apache-2.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add provides:
here for knative=${{package.full-version}}
and kn=${{package.full-version}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a provides for kn
but not for knative
mostly thinking that in future maybe we'll have a meta knative
package someday. 💭
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
knative client