Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Appearance Tools #2143

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

danielwrobert
Copy link
Contributor

@danielwrobert danielwrobert commented May 10, 2024

This provides support for spacing, border, typography, and color options, even without using theme.json.

Properties that should be added to various block settings are:

Additional references:

Screenshots

Image Block

Before After

Text Block

Before After

Layout Block

Before After

How to test the changes in this Pull Request:

  1. Insert an Image block in the editor and confirm that the sidebar settings have an additional tab added for Styles (see the After screenshot under Image Block above). Confirm changes to the new settings are reflected in the editor and on the front end.
  2. Insert a text block (Heading, Paragraph, etc) in the editor and confirm the Dimensions section added to the sidebar settings (see the After screenshot under Text Block above). This should allow additional spacing options (namely Margin). Confirm changes to the new settings are reflected in the editor and on the front end.
  3. Insert a layout block (Row or Column) in the editor and confirm added controls under the Styles tab in the sidebar settings(see the After screenshot under Layout Block above). Confirm changes to the new settings are reflected in the editor and on the front end.
  4. Smoke test additional Core blocks to ensure the new properties are added where expected and do not have any unintended side-effects.

Changelog

Add – support for Appearance Tools in Classic themes. #2143

@danielwrobert danielwrobert self-assigned this May 10, 2024
@danielwrobert danielwrobert force-pushed the add/appearance-tools-support branch from 3e952b8 to 99380fd Compare May 10, 2024 16:36
@danielwrobert danielwrobert marked this pull request as ready for review May 10, 2024 18:08
@danielwrobert danielwrobert requested review from a team and tjcafferkey and removed request for a team May 13, 2024 19:13
@danielwrobert danielwrobert added the type: enhancement The issue is a request for an enhancement. label May 13, 2024
Copy link
Contributor

@tjcafferkey tjcafferkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change tests well and looks good to me. Just wondering if the languages/storefront.pot file update is needed?

This provides support for spacing, border, typography, and color
options, even without using theme.json

See: https://wordpress.org/documentation/wordpress-version/version-6-5/#add-appearance-tools-to-classic-themes
@danielwrobert danielwrobert force-pushed the add/appearance-tools-support branch from 30d1ed5 to a06a4f7 Compare May 15, 2024 13:54
@danielwrobert
Copy link
Contributor Author

The change tests well and looks good to me. Just wondering if the languages/storefront.pot file update is needed?

Good point. While we're tracking it and should keep it up to date, it doesn't need to be included here.

I've removed that commit from this PR.

I also rebased with trunk and I see @gigitux already updated the POT file today so we're all set there!

@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label May 15, 2024
@danielwrobert danielwrobert merged commit 62caa79 into trunk May 15, 2024
7 checks passed
@danielwrobert danielwrobert deleted the add/appearance-tools-support branch May 15, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants