Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Price Feeds #29
base: main
Are you sure you want to change the base?
New Price Feeds #29
Changes from 1 commit
51e63e5
2c33985
80f08d1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: compound.solidity.constant-not-in-uppercase Note
Check warning
Code scanning / Semgrep OSS
There're no sanity checks for the constructor argument description_. Warning
Check warning
Code scanning / Semgrep OSS
There're no sanity checks for the constructor argument underlyingDecimals_. Warning
Check warning
Code scanning / Semgrep OSS
There're no sanity checks for the constructor argument underlyingPriceFeed_. Warning
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning
Check warning
Code scanning / Semgrep OSS
Consider making costructor payable to save gas. Warning
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.security.balancer-readonly-reentrancy-getrate Error
Check warning on line 13 in contracts/pricefeeds/RsETHScalingPriceFeed.sol
GitHub Actions / Contract linter
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: compound.solidity.constant-not-in-uppercase Note
Check warning
Code scanning / Semgrep OSS
There're no sanity checks for the constructor argument description_. Warning
Check warning
Code scanning / Semgrep OSS
There're no sanity checks for the constructor argument underlyingPriceFeed_. Warning
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning
Check warning
Code scanning / Semgrep OSS
Consider making costructor payable to save gas. Warning