[refactor] domain에서 history를 저장하기 때문에 service 레이어에서 history를 저장하는 로직 삭제

- history를 저장하는 책임을 도메인에게 넘겨버렸기 때문에 필요가 없어졌습니다.
woowa-techcamp-2024 · Aug 12, 2024 · ec96339 · ec96339
1 parent 581f4c5
commit ec96339
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/src/main/java/camp/woowak/lab/payaccount/service/PayAccountDepositService.java b/src/main/java/camp/woowak/lab/payaccount/service/PayAccountDepositService.java
@@ -6,7 +6,6 @@
 import camp.woowak.lab.payaccount.domain.PayAccount;
 import camp.woowak.lab.payaccount.domain.PayAccountHistory;
 import camp.woowak.lab.payaccount.exception.NotFoundAccountException;
-import camp.woowak.lab.payaccount.repository.PayAccountHistoryRepository;
 import camp.woowak.lab.payaccount.repository.PayAccountRepository;
 import camp.woowak.lab.payaccount.service.command.AccountTransactionCommand;
 import lombok.extern.slf4j.Slf4j;
@@ -15,12 +14,9 @@
 @Slf4j
 public class PayAccountDepositService {
 	private final PayAccountRepository payAccountRepository;
-	private final PayAccountHistoryRepository payAccountHistoryRepository;
 
-	public PayAccountDepositService(PayAccountRepository payAccountRepository,
-									PayAccountHistoryRepository payAccountHistoryRepository) {
+	public PayAccountDepositService(PayAccountRepository payAccountRepository) {
 		this.payAccountRepository = payAccountRepository;
-		this.payAccountHistoryRepository = payAccountHistoryRepository;
 	}
 
 	@Transactional
@@ -30,7 +26,6 @@ public long depositAccount(AccountTransactionCommand command) {
 
 		PayAccountHistory depositHistory = payAccount.deposit(command.amount());
 		log.info("A deposit of {} has been completed into Account ID {}.", command.amount(), command.payAccountId());
-		payAccountHistoryRepository.save(depositHistory);
 
 		return payAccount.getBalance();
 	}

diff --git a/src/main/java/camp/woowak/lab/payaccount/service/PayAccountWithdrawService.java b/src/main/java/camp/woowak/lab/payaccount/service/PayAccountWithdrawService.java
@@ -6,7 +6,6 @@
 import camp.woowak.lab.payaccount.domain.PayAccount;
 import camp.woowak.lab.payaccount.domain.PayAccountHistory;
 import camp.woowak.lab.payaccount.exception.NotFoundAccountException;
-import camp.woowak.lab.payaccount.repository.PayAccountHistoryRepository;
 import camp.woowak.lab.payaccount.repository.PayAccountRepository;
 import camp.woowak.lab.payaccount.service.command.AccountTransactionCommand;
 import lombok.extern.slf4j.Slf4j;
@@ -15,12 +14,9 @@
 @Slf4j
 public class PayAccountWithdrawService {
 	private final PayAccountRepository payAccountRepository;
-	private final PayAccountHistoryRepository payAccountHistoryRepository;
 
-	public PayAccountWithdrawService(PayAccountRepository payAccountRepository,
-									 PayAccountHistoryRepository payAccountHistoryRepository) {
+	public PayAccountWithdrawService(PayAccountRepository payAccountRepository) {
 		this.payAccountRepository = payAccountRepository;
-		this.payAccountHistoryRepository = payAccountHistoryRepository;
 	}
 
 	@Transactional
@@ -30,7 +26,6 @@ public long withdrawAccount(AccountTransactionCommand command) {
 
 		PayAccountHistory withdrawHistory = payAccount.withdraw(command.amount());
 		log.info("A withdrawal of {} has been completed from Account ID {}", command.amount(), command.payAccountId());
-		payAccountHistoryRepository.save(withdrawHistory);
 
 		return payAccount.getBalance();
 	}