Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 화면 구현 #139

Merged
merged 9 commits into from
Aug 26, 2024
Merged

[feat] 화면 구현 #139

merged 9 commits into from
Aug 26, 2024

Conversation

kimhyun5u
Copy link
Member

@kimhyun5u kimhyun5u commented Aug 24, 2024 •
edited
Loading

💡 다음 이슈를 해결했어요.

Issue Link - #136

  • 화면 기능 추가

💡 이슈를 처리하면서 추가된 코드가 있어요.

  • 화면를 구현했습니다...
  • 필요 api GET /cart { totalPrice: Long, totalAmount: Long}

✅ 셀프 체크리스트

  • 내 코드를 스스로 검토했습니다.
  • 필요한 테스트를 추가했습니다.
  • 모든 테스트를 통과합니다.
  • 브랜치 전략에 맞는 브랜치에 PR을 올리고 있습니다.
  • 커밋 메세지를 컨벤션에 맞추었습니다.
  • wiki를 수정했습니다.

@kimhyun5u kimhyun5u added the ✨ Feature 기능 개발 label Aug 24, 2024
@kimhyun5u kimhyun5u self-assigned this Aug 24, 2024
@kimhyun5u kimhyun5u linked an issue Aug 24, 2024 that may be closed by this pull request
[기능] 화면 구현 #136
Closed
@kimhyun5u @june-777
[feat] 프론트를 위한 API 추가
bbe55f1 
Co-authored-by: june-777 <wlwhswnsrl96@gmail.com>
@kimhyun5u kimhyun5u marked this pull request as ready for review August 26, 2024 07:39
june-777
june-777 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@june-777 june-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다!

@kimhyun5u kimhyun5u merged commit 952f424 into main Aug 26, 2024
1 check passed
@kimhyun5u kimhyun5u deleted the feature/136_kimhyun5u_기능-화면-구현 branch August 26, 2024 07:56
@Hyeon-Uk
Copy link
Contributor

LGTM ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-KoKo Dr-KoKo Dr-KoKo approved these changes

@june-777 june-777 june-777 approved these changes

@Hyeon-Uk Hyeon-Uk Awaiting requested review from Hyeon-Uk

Assignees

@kimhyun5u kimhyun5u

Labels
✨ Feature 기능 개발
Projects
3K1K Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[기능] 화면 구현
4 participants
@kimhyun5u @Hyeon-Uk @june-777 @Dr-KoKo