-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GlobalExceptionHandler 응답 방식 수정 #35
The head ref may contain hidden characters: "feature/33_kimhyun5u_globalexceptionhandler-\uC218\uC815"
GlobalExceptionHandler 응답 방식 수정 #35
Conversation
- 논의 - #31 에 따라 ResponseEntity 가 아닌 ProblemDetail 를 넘기도록 수정
- 예기치 못한 예외에 대한 로깅 추가
- 추후 Notion Hook 등록을 위한 기록
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…globalexceptionhandler-수정
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인완료입니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
머지하겠습니다! |
💡 다음 이슈를 해결했어요.
Issue Link - #33
Discussion Link - #31
💡 이슈를 처리하면서 추가된 코드가 있어요.
💡 이런 고민을 했어요.
log.error("[{exception type}]", e);
✅ 셀프 체크리스트