Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalExceptionHandler 응답 방식 수정 #35

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

kimhyun5u
Copy link
Member

@kimhyun5u kimhyun5u commented Aug 13, 2024

💡 다음 이슈를 해결했어요.

Issue Link - #33

Discussion Link - #31


💡 이슈를 처리하면서 추가된 코드가 있어요.

  • GlobalExceptionHandler:
    • ResponseEntity 가 아닌 ProblemDetail 로 전달하도록 변경
    • 추후 수정에 대한 TODO 작성
    • 예외 로깅 추가

💡 이런 고민을 했어요.

  • 예외 로깅을 어떻게 하면 좋을까요?
    • log.error("[{exception type}]", e);

✅ 셀프 체크리스트

  • 내 코드를 스스로 검토했습니다.
  • 필요한 테스트를 추가했습니다.
  • 모든 테스트를 통과합니다.
  • 브랜치 전략에 맞는 브랜치에 PR을 올리고 있습니다.
  • 커밋 메세지를 컨벤션에 맞추었습니다.
  • wiki를 수정했습니다.

- 논의 - #31 에 따라 ResponseEntity 가 아닌 ProblemDetail 를 넘기도록 수정
- 예기치 못한 예외에 대한 로깅 추가
- 추후 Notion Hook 등록을 위한 기록
@kimhyun5u kimhyun5u added ✨ Feature 기능 개발 ⚙ Setting 개발 환경 세팅 🔨 Refactor 코드 리팩토링 labels Aug 13, 2024
@kimhyun5u kimhyun5u added this to the 프로토타입 만들기 milestone Aug 13, 2024
@kimhyun5u kimhyun5u requested a review from a team August 13, 2024 03:47
@kimhyun5u kimhyun5u self-assigned this Aug 13, 2024
@kimhyun5u kimhyun5u linked an issue Aug 13, 2024 that may be closed by this pull request
Copy link
Member

@Dr-KoKo Dr-KoKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@june-777 june-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인완료입니다!

Copy link
Contributor

@Hyeon-Uk Hyeon-Uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kimhyun5u kimhyun5u merged commit 763fabf into main Aug 13, 2024
1 check passed
@kimhyun5u
Copy link
Member Author

머지하겠습니다!

@kimhyun5u kimhyun5u deleted the feature/33_kimhyun5u_globalexceptionhandler-수정 branch August 13, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 🔨 Refactor 코드 리팩토링 ⚙ Setting 개발 환경 세팅
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[기능] GlobalExceptionHandler 수정
4 participants