Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up Gravatar to 3.1.1 #23959

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Bump up Gravatar to 3.1.1 #23959

merged 2 commits into from
Jan 9, 2025

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Jan 8, 2025

Fixes #

Bumps up Gravatar to 3.1.1 to bring in a bug fix.

To test:

The fix can be tested Automattic/Gravatar-SDK-iOS#623

Regression Notes

  1. Potential unintended areas of impact
    No change in the Jetpack code.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  1. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@pinarol pinarol added the Gravatar Gravatar SDK related updates label Jan 8, 2025
@pinarol pinarol added this to the 25.6 ❄️ milestone Jan 8, 2025
@pinarol pinarol requested a review from etoledom January 8, 2025 09:23
@pinarol pinarol self-assigned this Jan 8, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 8, 2025

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ This PR is assigned to the milestone 25.7. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 8, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23959-227a5f7
Version25.6
Bundle IDcom.jetpack.alpha
Commit227a5f7
App Center Buildjetpack-installable-builds #10340
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@pinarol pinarol modified the milestones: 25.6 ❄️, 25.7 Jan 8, 2025
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 8, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23959-227a5f7
Version25.6
Bundle IDorg.wordpress.alpha
Commit227a5f7
App Center BuildWPiOS - One-Offs #11307
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@andrewdmontgomery andrewdmontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integeration looks good. The fix works on simulator and device.

# Conflicts:
#	WordPress.xcworkspace/xcshareddata/swiftpm/Package.resolved
@pinarol pinarol enabled auto-merge January 8, 2025 17:07
@pinarol pinarol added this pull request to the merge queue Jan 9, 2025
Merged via the queue into trunk with commit 63b0f42 Jan 9, 2025
25 checks passed
@pinarol pinarol deleted the wppinar/bump-gravatar-to-3.1.1 branch January 9, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gravatar Gravatar SDK related updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants