Skip to content

Commit

Permalink
applied the same convention used for metric set in page spec
Browse files Browse the repository at this point in the history
  • Loading branch information
kungfucraig committed Jan 8, 2025
1 parent 1b3c192 commit 06773ff
Showing 1 changed file with 8 additions and 11 deletions.
19 changes: 8 additions & 11 deletions src/main/proto/wfa/measurement/reporting/v2alpha/page.proto
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,7 @@ message Page {
// Metrics for the entire reporting_unit.
message ReportingUnitMetricSet {
// The metrics for the union of the reporting_unit components
BasicMetricSet basic_metric_set = 1
[(google.api.field_behavior) = IMMUTABLE];
BasicMetricSet basic = 1 [(google.api.field_behavior) = IMMUTABLE];

// The stacked incremental reach of the ReportingUnit.
//
Expand All @@ -154,18 +153,17 @@ message Page {
repeated int32 stacked_incremental_reach = 2;
}
// Metrics for the whole reporting_unit
ReportingUnitMetricSet reporting_unit_metric_set = 2;
ReportingUnitMetricSet reporting_unit = 2;

// Metrics for a single component of the reporting_unit.
message ComponentMetricSet {
// The basic metrics for this component
BasicMetricSet basic_metric_set = 1
[(google.api.field_behavior) = IMMUTABLE];
BasicMetricSet basic = 1 [(google.api.field_behavior) = IMMUTABLE];

// The component's unique reach
int32 unique_reach = 2 [(google.api.field_behavior) = IMMUTABLE];
}
// Entry for the `component_metric_sets` map.
// Entry for `components` map.
message ComponentMetricSetMapEntry {
// Map entry key.
//
Expand All @@ -184,7 +182,7 @@ message Page {
];
}
// Map of `component` to `ComponentMetricSet`.
repeated ComponentMetricSetMapEntry component_metric_sets = 3
repeated ComponentMetricSetMapEntry components = 3
[(google.api.field_behavior) = IMMUTABLE];

// Metrics for the intersection of the components of the reporting_unit
Expand All @@ -195,12 +193,11 @@ message Page {
// ReportingSet resource names when used with an AdvancedReport.
repeated string components = 1 [(google.api.field_behavior) = IMMUTABLE];
// Basic metrics for the intersection of the components
BasicMetricSet basic_metric_set = 2
[(google.api.field_behavior) = IMMUTABLE];
BasicMetricSet basic = 2 [(google.api.field_behavior) = IMMUTABLE];
}
// The metrics for the requested intersections
repeated ComponentIntersectionMetricSet component_intersection_metric_set =
4 [(google.api.field_behavior) = IMMUTABLE];
repeated ComponentIntersectionMetricSet component_intersections = 4
[(google.api.field_behavior) = IMMUTABLE];
}

// The metadata and metrics for a impression aualification filter
Expand Down

0 comments on commit 06773ff

Please sign in to comment.