Updates from review

world-federation-of-advertisers · Dec 17, 2024 · 6eb9bd5 · 6eb9bd5
1 parent 1f3db68
commit 6eb9bd5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/main/proto/wfa/measurement/reporting/v2alpha/basic_report.proto b/src/main/proto/wfa/measurement/reporting/v2alpha/basic_report.proto
@@ -90,7 +90,7 @@ message BasicReport {
 
   // The set of filters for this report.
   //
-  // An entry in this map must exist for every ReportingMediaType used in
+  // An entry in this set must exist for every ReportingMediaType used in
   // any PageSpec.
   repeated ReportingImpressionQualificationFilter
       impression_qualification_filters = 5 [

diff --git a/src/main/proto/wfa/measurement/reporting/v2alpha/page.proto b/src/main/proto/wfa/measurement/reporting/v2alpha/page.proto
@@ -110,8 +110,10 @@ message CalculationSpec {
       // The value of the event template to filter
       message FieldValue {
         oneof value {
-          // Used when the event template field is a string or enum
+          // Used when the event template field is a string
           string string_value = 1 [(google.api.field_behavior) = IMMUTABLE];
+          // Used when the event template field is an enum
+          string enum_value = 2 [(google.api.field_behavior) = IMMUTABLE];
         }
       }
       // The value of the event_template_field to filter on.