Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation issues and Windows run script #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daevem
Copy link

@daevem daevem commented Jun 9, 2021

In this pull request, I'm simply solving some issues I ran into when trying to install your lib on windows 10.
Relates to #13 and #15.

There are three simple changes:

  1. Dockerfile.cpu: the installation was not being successful due to the missed installation of miniconda2. According to this asnwer, the issue was given by curl, which does not automatically follow redirects unless the option -L is provided. This indeed solved the issue.
  2. requirements.txt: imageio package was required to be within a certain version range, but without clearly stating it inside the requirements.txt document, the package installer was installing the latest version, thus the addition of the version specification.
  3. run_powershell.ps1: simple script which mimics launch.sh, but in a PowerShell compatible mode.

Thanks for your work!

daevem added 2 commits June 9, 2021 17:01
…ving miniconda2; Modify requirements.txt by specifying a non-conflicting version of imageio; Add run_powershell.ps1 script to run on Win10 powershell
Copy link

@ccantarero91 ccantarero91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on MAC the changes (not the one related with powershell) and worked!
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants