Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cif 303 #102

Merged
merged 12 commits into from
Jan 10, 2025
Merged

Cif 303 #102

merged 12 commits into from
Jan 10, 2025

Conversation

chrowe
Copy link
Contributor

@chrowe chrowe commented Dec 31, 2024

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • Yes, the URL of the associated JIRA ticket is https://gfw.atlassian.net/browse/CIF-XXX. The PR name follows the format [CIF-XXX] my subject.

  • No, this is a documentation update. The PR name follows the format [DOCS] my subject.

What changes were proposed in this PR?

How was this patch tested?

Did this PR include necessary documentation updates?

  • Yes, I am adding a new API feature.
  • Yes, I have updated the documentation update.
  • No, this PR does not affect any public API so no need to change the docs.

@chrowe chrowe requested a review from weiqi-tori December 31, 2024 14:45
@arshdoda
Copy link
Contributor

arshdoda commented Jan 7, 2025

These script is to compute the layers and indicators using CIF and has no impact on the cif itself. There is no testing required for scripts at CIF level.

However, dotenv has been used in the scripts for now it has been removed from environment.yml and setup.py

Copy link
Member

@weiqi-tori weiqi-tori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  1. Generate ESA world cover layer and upload to S3
  2. Generate OSM open space layer and upload to S3
  3. Calculate urban open space indicator

Maybe should remove the Carto credential in calculate_indicators.py before merging.

@S-AI-F S-AI-F merged commit 97ebd98 into main Jan 10, 2025
1 check passed
@S-AI-F S-AI-F deleted the CIF-303 branch January 10, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants