-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cif 303 #102
Conversation
These script is to compute the layers and indicators using CIF and has no impact on the cif itself. There is no testing required for scripts at CIF level. However, dotenv has been used in the scripts for now it has been removed from environment.yml and setup.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested:
- Generate ESA world cover layer and upload to S3
- Generate OSM open space layer and upload to S3
- Calculate urban open space indicator
Maybe should remove the Carto credential in calculate_indicators.py
before merging.
Did you read the Contributor Guide?
Yes, I have read How to contribute
No, I haven't read it.
Is this PR related to a JIRA ticket?
Yes, the URL of the associated JIRA ticket is https://gfw.atlassian.net/browse/CIF-XXX. The PR name follows the format
[CIF-XXX] my subject
.No, this is a documentation update. The PR name follows the format
[DOCS] my subject
.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?