Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fire alerts): experiment with ports and adapters approach #133

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

gtempus
Copy link
Contributor

@gtempus gtempus commented Jan 31, 2024

https://alistair.cockburn.us/hexagonal-architecture/ https://8thlight.com/insights/a-color-coded-guide-to-ports-and-adapters

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@gtempus gtempus requested a review from dmannarino January 31, 2024 17:41
@gtempus gtempus force-pushed the refactor--ports-and-adapters branch from 3a8d4c6 to 4344c38 Compare April 30, 2024 16:23
@gtempus gtempus force-pushed the refactor--ports-and-adapters branch from 4344c38 to 34724e2 Compare May 1, 2024 22:09
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 54.41176% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 78.48%. Comparing base (db8de7d) to head (34724e2).

Files Patch % Lines
.../domain/services/nasa_viirs_fire_alerts_service.py 42.10% 11 Missing ⚠️
app/adapters/data_api_geostore_geometry_adapter.py 52.63% 9 Missing ⚠️
app/routes/dynamic_vector_tiles.py 28.57% 5 Missing ⚠️
app/domain/services/geostore_geometry_service.py 66.66% 2 Missing ⚠️
app/routes/umd_modis_burned_areas/vector_tiles.py 66.66% 2 Missing ⚠️
app/domain/ports/geostore_geometry_port.py 75.00% 1 Missing ⚠️
app/routes/nasa_viirs_fire_alerts/vector_tiles.py 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #133      +/-   ##
==========================================
- Coverage   78.74%   78.48%   -0.26%     
==========================================
  Files          53       57       +4     
  Lines        1778     1817      +39     
==========================================
+ Hits         1400     1426      +26     
- Misses        378      391      +13     
Flag Coverage Δ
unittests 78.48% <54.41%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants