add new relic monitoring #138
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #138 +/- ##
=======================================
Coverage 79.46% 79.46%
=======================================
Files 56 56
Lines 1870 1870
=======================================
Hits 1486 1486
Misses 384 384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
terraform/vars/terraform-dev.tfvars
Outdated
| @@ -4,3 +4,4 @@ tile_cache_url = "dev-tiles.globalforestwatch.org" | |||
| desired_count = 1 | |||
| auto_scaling_min_capacity = 1 | |||
| auto_scaling_max_capacity = 5 | |||
| new_relic_license_key_arn = "arn:aws:secretsmanager:us-east-1:563860007740:secret:newrelic/license_key-lolw24" | |||
There was a problem hiding this comment.
Just curious. We don't usually put arns directly in the terraform, right? But I guess this is OK because ARNs for secrets in the secret manager do no change over the long term? (I see that these arns are already in the terraform for the data API as well.)
There was a problem hiding this comment.
Yeah, the ARNs are not expected to change but I agree hard coding them isn't ideal. I have made a minor change in 7cfdbd9 where TF fetches the secret arn from aws using the name attribute that's the same across environments and not editable.
add new relic monitoring
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
No application performance monitoring
What is the new behavior?
Adds new relic APM
Does this introduce a breaking change?
Other information