Remove protected fields, in subclasses #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruwanta
reviewed
Nov 13, 2019
| @@ -113,7 +113,7 @@ | |||
| */ | |||
| public class PrivilegedConsentManagerImpl implements PrivilegedConsentManager { | |||
|
|
|||
| protected ConsentManager consentManager; | |||
| ConsentManager consentManager; | |||
There was a problem hiding this comment.
Better this be private, not "default"
|
@wijith7, please fix the title to make it more understandable. Please the linked also more descriptive. |
wijith7
changed the title
wijith7
changed the title
wijith7
changed the title
wijith7
changed the title
ruwanta
approved these changes
Dec 5, 2019
IsuraD
pushed a commit
to IsuraD/carbon-consent-management
that referenced
this pull request
Apr 28, 2020
IsuraD
pushed a commit
to IsuraD/carbon-consent-management
that referenced
this pull request
Apr 28, 2020
…evelopment iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed the issue [1]
[1] . #168