Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDL comparison tests for contribution functions for various ions #257

Merged
merged 20 commits into from
Jan 19, 2024

Conversation

wtbarnes
Copy link
Owner

@wtbarnes wtbarnes commented Jan 13, 2024

This PR adds several tests that compare the output from fiasco and CHIANTI IDL for the contribution functions for several ions. The IDL results are also saved and included here, with the intention of including comparison plots in the documentation.

The IDL tests are now run on the CI using the cached results. Additionally, the hash checking for the files has been refactored a bit and a hash generation function has been added as well as a JSON files with all hashes for the current version of the database.

Also fixes #256

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (2d8e308) 90.56% compared to head (f0989ef) 91.90%.

Files Patch % Lines
fiasco/tests/idl/helpers.py 70.96% 9 Missing ⚠️
fiasco/conftest.py 84.61% 2 Missing ⚠️
fiasco/tests/idl/conftest.py 50.00% 2 Missing ⚠️
fiasco/tests/idl/test_idl_continuum.py 93.75% 1 Missing ⚠️
fiasco/util/setup_db.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   90.56%   91.90%   +1.34%     
==========================================
  Files          36       38       +2     
  Lines        2670     2718      +48     
==========================================
+ Hits         2418     2498      +80     
+ Misses        252      220      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtbarnes wtbarnes marked this pull request as ready for review January 18, 2024 00:36
@wtbarnes wtbarnes merged commit 586984f into main Jan 19, 2024
17 of 18 checks passed
@wtbarnes wtbarnes deleted the idl-goft-comparison-tests branch January 19, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use MANIFEST.in file to exclude unneeded files from distributed package
2 participants