-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rescript conversion #40
Open
sacarr
wants to merge
7
commits into
wyze:master
Choose a base branch
from
sacarr:rescript-conversion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om-testing-library
hello, i am getting
it seems that rescript-dom-testing-library@^0.8.0 doest not exists
|
This is pending PR #31 (wyze/bs-dom-testing-library#31). As that PR was not accepted, I started working on an independent upgrade to Rescript 9 (https://github.com/sacarr/rescript-testing-library). This package has not been released as I have been focused elsewhere. The renderHook wrappers need more work before I release.
The dom and react packages were pass tests at the end of February when I last worked on them, but probably now need updates to dependencies after such a long delay.
I’m recovering slowly and hope to finish renderHook and release all three packages soon.
Stef
Sent from my iPhone
… On Jul 2, 2022, at 6:25 PM, Ruiz Martin ***@***.***> wrote:
hello, i am getting
pm ERR! code ETARGET
npm ERR! notarget No matching version found for rescript-dom-testing-library@^0.8.0.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
it seems that rescript-dom-testing-library@^0.8.0 doest not exists
$ npm view rescript-dom-testing-library versions
[
'0.0.0-semantic-released',
'1.0.0',
'1.0.1',
'1.0.2',
'1.1.0',
'1.2.2',
'1.3.0',
'1.4.0',
'1.5.0',
'1.6.0',
'1.7.0',
'1.8.0',
'1.9.0',
'1.10.0',
'1.11.0',
'1.12.0',
'1.13.0',
'1.14.0',
'1.14.1',
'1.15.0',
'2.1.1'
]
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
awesome, kudos for you! waiting eagerly your package release ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wyze, This pull request updates bs-react-testing-library to Rescript 9.1.4, Jest 27.3.1. It is a companion to wyze/bs-dom-testing-library PR #31.
Changes include:
|>
operator. Sources were updated to use the preferred->
operator.|>
with->
, Js.Promise API with @ryyppy/rescript-promise APIimport * as React from "react"
as opposed toimport React from "react
)". The rescript-compiler team is aware of this issue when using ES6 module syntax with code bases like React.