Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transforms: (memref-to-dsd) Support 1d subview of nd memref #3653

Merged
merged 11 commits into from
Jan 6, 2025
Merged

transforms: (memref-to-dsd) Support 1d subview of nd memref #3653

merged 11 commits into from
Jan 6, 2025

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Dec 18, 2024

No description provided.

@n-io n-io added the transformations Changes or adds a transformatio label Dec 18, 2024
@n-io n-io self-assigned this Dec 18, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (2ce4059) to head (89b8da6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3653   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files         467      467           
  Lines       58511    58531   +20     
  Branches     5642     5643    +1     
=======================================
+ Hits        53427    53449   +22     
+ Misses       3633     3632    -1     
+ Partials     1451     1450    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io marked this pull request as ready for review December 19, 2024 15:27
@n-io n-io requested review from dk949 and emmau678 December 19, 2024 15:27
@n-io n-io mentioned this pull request Dec 17, 2024
Open
50 tasks
dk949
dk949 reviewed Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused on the memref_to_dsd part

xdsl/transforms/lower_csl_stencil.py Show resolved Hide resolved
xdsl/transforms/memref_to_dsd.py Outdated Show resolved Hide resolved
xdsl/transforms/memref_to_dsd.py Show resolved Hide resolved
@n-io n-io requested a review from dk949 December 20, 2024 20:59
dk949
dk949 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@n-io n-io merged commit ad04c3f into main Jan 6, 2025
16 checks passed
@n-io n-io deleted the nicolai/memref-to-dsd-2d-into-1d branch January 6, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dk949 dk949 dk949 approved these changes

@emmau678 emmau678 Awaiting requested review from emmau678

Assignees

@n-io n-io

Labels
transformations Changes or adds a transformatio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-io @dk949