PPPoE: miscellaneous improvements #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laarmen
force-pushed
the
pppoe_headers_cleanup
branch
from
cac1491 to
1246687
Compare
micron10
reviewed
Dec 20, 2020
There was a problem hiding this comment.
With this patch not connect pppoe users with this error :
[2020-12-20 12:24:55]: debug: vlan-mon: notify 4 100 8863 0
[2020-12-20 12:24:55]: info: pppoe: create vlan vlan100 parent eth1
[2020-12-20 12:25:00]: warn: pppoe: discarding packet (unsupported version 0)
[2020-12-20 12:25:10]: warn: pppoe: discarding packet (unsupported version 0)
[2020-12-20 12:25:25]: info: pppoe: remove vlan vlan100
|
Hi, thank you for testing this, I appreciate it very much. Could you share a bit more details about the error case? Is it on any client, or only some of them ? Are you running on amd64 or 32-bit x86? |
|
Hi
Test on Proxmox latest version
cpu is Ryzen 7 1800X
in virtual machine is:
lscpu
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 40 bits physical, 48 bits virtual
CPU(s): 8
On-line CPU(s) list: 0-7
Thread(s) per core: 1
Core(s) per socket: 8
Socket(s): 1
NUMA node(s): 1
Vendor ID: AuthenticAMD
CPU family: 23
Model: 1
Model name: AMD EPYC Processor
Stepping: 2
CPU MHz: 3842.459
BogoMIPS: 7684.91
Hypervisor vendor: KVM
Virtualization type: full
L1d cache: 256 KiB
L1i cache: 512 KiB
L2 cache: 4 MiB
L3 cache: 8 MiB
NUMA node0 CPU(s): 0-7
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Vulnerable: __user pointer sanitization
and usercopy barriers only; n o swapgs
barriers
Vulnerability Spectre v2: Vulnerable, STIBP: disabled
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Flags: fpu vme de pse tsc msr pae mce cx8 apic
sep mtrr pge mca cmov pat pse 36 clflush
mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rd
tscp lm rep_good nopl cpuid extd_apicid pni pclmulqdq ssse3
fma cx16 sse4_1 sse4_2 x2apic movbe popcnt
aes xsave avx f16c rdrand hyperviso r
lahf_lm cmp_legacy cr8_legacy abm sse4a misalignsse 3dnowprefetch o
svw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2
rdseed adx smap clfl ushopt sha_ni xsaveopt
xsavec xgetbv1 arat
i have online one customer in this test server.
…On Sun, Dec 20, 2020, 17:33 Simon Chopin ***@***.***> wrote:
Hi, thank you for testing this, I appreciate it very much.
Could you share a bit more details about the error case? Is it on any
client, or only some of them ? Are you running on amd64 or 32-bit x86?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#140 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCWD5EYBI76OEIUIWNHB3TSVYKNJANCNFSM4OFPZQ4A>
.
|
|
i try to change qemu cpu to intel SandyBridge and get same error
after remove patch all work fine
…On Sun, Dec 20, 2020, 17:39 Martin Zaharinov ***@***.***> wrote:
Hi
Test on Proxmox latest version
cpu is Ryzen 7 1800X
in virtual machine is:
lscpu
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 40 bits physical, 48 bits virtual
CPU(s): 8
On-line CPU(s) list: 0-7
Thread(s) per core: 1
Core(s) per socket: 8
Socket(s): 1
NUMA node(s): 1
Vendor ID: AuthenticAMD
CPU family: 23
Model: 1
Model name: AMD EPYC Processor
Stepping: 2
CPU MHz: 3842.459
BogoMIPS: 7684.91
Hypervisor vendor: KVM
Virtualization type: full
L1d cache: 256 KiB
L1i cache: 512 KiB
L2 cache: 4 MiB
L3 cache: 8 MiB
NUMA node0 CPU(s): 0-7
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Vulnerable: __user pointer sanitization
and usercopy barriers only; n o swapgs
barriers
Vulnerability Spectre v2: Vulnerable, STIBP: disabled
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Flags: fpu vme de pse tsc msr pae mce cx8 apic
sep mtrr pge mca cmov pat pse 36 clflush
mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rd
tscp lm rep_good nopl cpuid extd_apicid pni pclmulqdq ssse3
fma cx16 sse4_1 sse4_2 x2apic movbe popcnt
aes xsave avx f16c rdrand hyperviso r
lahf_lm cmp_legacy cr8_legacy abm sse4a misalignsse 3dnowprefetch o
svw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2
rdseed adx smap clfl ushopt sha_ni xsaveopt
xsavec xgetbv1 arat
i have online one customer in this test server.
On Sun, Dec 20, 2020, 17:33 Simon Chopin ***@***.***> wrote:
> Hi, thank you for testing this, I appreciate it very much.
>
> Could you share a bit more details about the error case? Is it on any
> client, or only some of them ? Are you running on amd64 or 32-bit x86?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#140 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADCWD5EYBI76OEIUIWNHB3TSVYKNJANCNFSM4OFPZQ4A>
> .
>
|
|
Do you have idea from where is come this bug ? and do you have fix for them
?
На нд, 20.12.2020 г. в 18:54 ч. Martin Zaharinov <micron10@gmail.com>
написа:
… i try to change qemu cpu to intel SandyBridge and get same error
after remove patch all work fine
On Sun, Dec 20, 2020, 17:39 Martin Zaharinov ***@***.***> wrote:
> Hi
> Test on Proxmox latest version
>
> cpu is Ryzen 7 1800X
>
> in virtual machine is:
>
> lscpu
> Architecture: x86_64
> CPU op-mode(s): 32-bit, 64-bit
> Byte Order: Little Endian
> Address sizes: 40 bits physical, 48 bits virtual
> CPU(s): 8
> On-line CPU(s) list: 0-7
> Thread(s) per core: 1
> Core(s) per socket: 8
> Socket(s): 1
> NUMA node(s): 1
> Vendor ID: AuthenticAMD
> CPU family: 23
> Model: 1
> Model name: AMD EPYC Processor
> Stepping: 2
> CPU MHz: 3842.459
> BogoMIPS: 7684.91
> Hypervisor vendor: KVM
> Virtualization type: full
> L1d cache: 256 KiB
> L1i cache: 512 KiB
> L2 cache: 4 MiB
> L3 cache: 8 MiB
> NUMA node0 CPU(s): 0-7
> Vulnerability Itlb multihit: Not affected
> Vulnerability L1tf: Not affected
> Vulnerability Mds: Not affected
> Vulnerability Meltdown: Not affected
> Vulnerability Spec store bypass: Vulnerable
> Vulnerability Spectre v1: Vulnerable: __user pointer sanitization
> and usercopy barriers only; n o swapgs
> barriers
> Vulnerability Spectre v2: Vulnerable, STIBP: disabled
> Vulnerability Srbds: Not affected
> Vulnerability Tsx async abort: Not affected
> Flags: fpu vme de pse tsc msr pae mce cx8 apic
> sep mtrr pge mca cmov pat pse 36 clflush
> mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rd
> tscp lm rep_good nopl cpuid extd_apicid pni pclmulqdq ssse3
> fma cx16 sse4_1 sse4_2 x2apic movbe popcnt
> aes xsave avx f16c rdrand hyperviso r
> lahf_lm cmp_legacy cr8_legacy abm sse4a misalignsse 3dnowprefetch o
> svw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2
> rdseed adx smap clfl ushopt sha_ni xsaveopt
> xsavec xgetbv1 arat
>
> i have online one customer in this test server.
>
>
>
> On Sun, Dec 20, 2020, 17:33 Simon Chopin ***@***.***>
> wrote:
>
>> Hi, thank you for testing this, I appreciate it very much.
>>
>> Could you share a bit more details about the error case? Is it on any
>> client, or only some of them ? Are you running on amd64 or 32-bit x86?
>>
>> —
>> You are receiving this because you commented.
>> Reply to this email directly, view it on GitHub
>> <#140 (comment)>, or
>> unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ADCWD5EYBI76OEIUIWNHB3TSVYKNJANCNFSM4OFPZQ4A>
>> .
>>
>
|
|
Simon if you havw fix for this i will test
…On Mon, Dec 21, 2020, 21:20 Martin Zaharinov ***@***.***> wrote:
Do you have idea from where is come this bug ? and do you have fix for
them ?
На нд, 20.12.2020 г. в 18:54 ч. Martin Zaharinov ***@***.***>
написа:
> i try to change qemu cpu to intel SandyBridge and get same error
>
> after remove patch all work fine
>
> On Sun, Dec 20, 2020, 17:39 Martin Zaharinov ***@***.***> wrote:
>
>> Hi
>> Test on Proxmox latest version
>>
>> cpu is Ryzen 7 1800X
>>
>> in virtual machine is:
>>
>> lscpu
>> Architecture: x86_64
>> CPU op-mode(s): 32-bit, 64-bit
>> Byte Order: Little Endian
>> Address sizes: 40 bits physical, 48 bits virtual
>> CPU(s): 8
>> On-line CPU(s) list: 0-7
>> Thread(s) per core: 1
>> Core(s) per socket: 8
>> Socket(s): 1
>> NUMA node(s): 1
>> Vendor ID: AuthenticAMD
>> CPU family: 23
>> Model: 1
>> Model name: AMD EPYC Processor
>> Stepping: 2
>> CPU MHz: 3842.459
>> BogoMIPS: 7684.91
>> Hypervisor vendor: KVM
>> Virtualization type: full
>> L1d cache: 256 KiB
>> L1i cache: 512 KiB
>> L2 cache: 4 MiB
>> L3 cache: 8 MiB
>> NUMA node0 CPU(s): 0-7
>> Vulnerability Itlb multihit: Not affected
>> Vulnerability L1tf: Not affected
>> Vulnerability Mds: Not affected
>> Vulnerability Meltdown: Not affected
>> Vulnerability Spec store bypass: Vulnerable
>> Vulnerability Spectre v1: Vulnerable: __user pointer sanitization
>> and usercopy barriers only; n o swapgs
>> barriers
>> Vulnerability Spectre v2: Vulnerable, STIBP: disabled
>> Vulnerability Srbds: Not affected
>> Vulnerability Tsx async abort: Not affected
>> Flags: fpu vme de pse tsc msr pae mce cx8 apic
>> sep mtrr pge mca cmov pat pse 36 clflush
>> mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rd
>> tscp lm rep_good nopl cpuid extd_apicid pni pclmulqdq ssse3
>> fma cx16 sse4_1 sse4_2 x2apic movbe popcnt
>> aes xsave avx f16c rdrand hyperviso r
>> lahf_lm cmp_legacy cr8_legacy abm sse4a misalignsse 3dnowprefetch o
>> svw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2
>> rdseed adx smap clfl ushopt sha_ni xsaveopt
>> xsavec xgetbv1 arat
>>
>> i have online one customer in this test server.
>>
>>
>>
>> On Sun, Dec 20, 2020, 17:33 Simon Chopin ***@***.***>
>> wrote:
>>
>>> Hi, thank you for testing this, I appreciate it very much.
>>>
>>> Could you share a bit more details about the error case? Is it on any
>>> client, or only some of them ? Are you running on amd64 or 32-bit x86?
>>>
>>> —
>>> You are receiving this because you commented.
>>> Reply to this email directly, view it on GitHub
>>> <#140 (comment)>,
>>> or unsubscribe
>>> <https://github.com/notifications/unsubscribe-auth/ADCWD5EYBI76OEIUIWNHB3TSVYKNJANCNFSM4OFPZQ4A>
>>> .
>>>
>>
|
|
I'll see what I can do after the holidays.
Le jeu. 24 déc. 2020 à 18:43, micron10 <notifications@github.com> a écrit :
… Simon if you havw fix for this i will test
On Mon, Dec 21, 2020, 21:20 Martin Zaharinov ***@***.***> wrote:
> Do you have idea from where is come this bug ? and do you have fix for
> them ?
>
> На нд, 20.12.2020 г. в 18:54 ч. Martin Zaharinov ***@***.***>
> написа:
>
>> i try to change qemu cpu to intel SandyBridge and get same error
>>
>> after remove patch all work fine
>>
>> On Sun, Dec 20, 2020, 17:39 Martin Zaharinov ***@***.***>
wrote:
>>
>>> Hi
>>> Test on Proxmox latest version
>>>
>>> cpu is Ryzen 7 1800X
>>>
>>> in virtual machine is:
>>>
>>> lscpu
>>> Architecture: x86_64
>>> CPU op-mode(s): 32-bit, 64-bit
>>> Byte Order: Little Endian
>>> Address sizes: 40 bits physical, 48 bits virtual
>>> CPU(s): 8
>>> On-line CPU(s) list: 0-7
>>> Thread(s) per core: 1
>>> Core(s) per socket: 8
>>> Socket(s): 1
>>> NUMA node(s): 1
>>> Vendor ID: AuthenticAMD
>>> CPU family: 23
>>> Model: 1
>>> Model name: AMD EPYC Processor
>>> Stepping: 2
>>> CPU MHz: 3842.459
>>> BogoMIPS: 7684.91
>>> Hypervisor vendor: KVM
>>> Virtualization type: full
>>> L1d cache: 256 KiB
>>> L1i cache: 512 KiB
>>> L2 cache: 4 MiB
>>> L3 cache: 8 MiB
>>> NUMA node0 CPU(s): 0-7
>>> Vulnerability Itlb multihit: Not affected
>>> Vulnerability L1tf: Not affected
>>> Vulnerability Mds: Not affected
>>> Vulnerability Meltdown: Not affected
>>> Vulnerability Spec store bypass: Vulnerable
>>> Vulnerability Spectre v1: Vulnerable: __user pointer sanitization
>>> and usercopy barriers only; n o swapgs
>>> barriers
>>> Vulnerability Spectre v2: Vulnerable, STIBP: disabled
>>> Vulnerability Srbds: Not affected
>>> Vulnerability Tsx async abort: Not affected
>>> Flags: fpu vme de pse tsc msr pae mce cx8 apic
>>> sep mtrr pge mca cmov pat pse 36 clflush
>>> mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rd
>>> tscp lm rep_good nopl cpuid extd_apicid pni pclmulqdq ssse3
>>> fma cx16 sse4_1 sse4_2 x2apic movbe popcnt
>>> aes xsave avx f16c rdrand hyperviso r
>>> lahf_lm cmp_legacy cr8_legacy abm sse4a misalignsse 3dnowprefetch o
>>> svw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2
>>> rdseed adx smap clfl ushopt sha_ni xsaveopt
>>> xsavec xgetbv1 arat
>>>
>>> i have online one customer in this test server.
>>>
>>>
>>>
>>> On Sun, Dec 20, 2020, 17:33 Simon Chopin ***@***.***>
>>> wrote:
>>>
>>>> Hi, thank you for testing this, I appreciate it very much.
>>>>
>>>> Could you share a bit more details about the error case? Is it on any
>>>> client, or only some of them ? Are you running on amd64 or 32-bit x86?
>>>>
>>>> —
>>>> You are receiving this because you commented.
>>>> Reply to this email directly, view it on GitHub
>>>> <#140 (comment)>,
>>>> or unsubscribe
>>>> <
https://github.com/notifications/unsubscribe-auth/ADCWD5EYBI76OEIUIWNHB3TSVYKNJANCNFSM4OFPZQ4A
>
>>>> .
>>>>
>>>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#140 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEQ4NOXTIZJJ5MUQ4LURPTSWN4SLANCNFSM4OFPZQ4A>
.
|
This way, the client code doesn't need to know the intrinsics of how exactly the packet data is encoded within the payload, it can just directly access the structure fields. A small theoretical bonus is that it makes the code a bit more portable as the size of an `int` isn't guaranteed to be 4 bytes on every platform. Granted, it is 32-bit on all the platforms supported by Debian, and the Linux kernel pretty much makes the same assumption, but it doesn't cost anything. v2: Fix the pointer arithmetic bug that rendered the whole patch non-functional Signed-off-by: Simon Chopin <s.chopin@alphalink.fr> fixup
This patch is more for quality of life for development : if the headers aren't self-contained, the tooling tends to complain about incomplete types and undefined constants when editing the header file. Signed-off-by: Simon Chopin <s.chopin@alphalink.fr>
laarmen
force-pushed
the
pppoe_headers_cleanup
branch
from
1246687 to
64e6dcd
Compare
|
Allright, this was a very silly mistake, and the reason I didn't catch it
is that my test script
failed silently even before getting to mounting a PPP.
That's what I get for trying to upstream my changes in small batches as
early as possible: each PR isn't as heavily
tested as it should :-/
…On Thu, Dec 24, 2020 at 6:51 PM Simon Chopin ***@***.***> wrote:
I'll see what I can do after the holidays.
Le jeu. 24 déc. 2020 à 18:43, micron10 ***@***.***> a
écrit :
> Simon if you havw fix for this i will test
>
> On Mon, Dec 21, 2020, 21:20 Martin Zaharinov ***@***.***> wrote:
>
> > Do you have idea from where is come this bug ? and do you have fix for
> > them ?
> >
> > На нд, 20.12.2020 г. в 18:54 ч. Martin Zaharinov ***@***.***>
> > написа:
> >
> >> i try to change qemu cpu to intel SandyBridge and get same error
> >>
> >> after remove patch all work fine
> >>
> >> On Sun, Dec 20, 2020, 17:39 Martin Zaharinov ***@***.***>
> wrote:
> >>
> >>> Hi
> >>> Test on Proxmox latest version
> >>>
> >>> cpu is Ryzen 7 1800X
> >>>
> >>> in virtual machine is:
> >>>
> >>> lscpu
> >>> Architecture: x86_64
> >>> CPU op-mode(s): 32-bit, 64-bit
> >>> Byte Order: Little Endian
> >>> Address sizes: 40 bits physical, 48 bits virtual
> >>> CPU(s): 8
> >>> On-line CPU(s) list: 0-7
> >>> Thread(s) per core: 1
> >>> Core(s) per socket: 8
> >>> Socket(s): 1
> >>> NUMA node(s): 1
> >>> Vendor ID: AuthenticAMD
> >>> CPU family: 23
> >>> Model: 1
> >>> Model name: AMD EPYC Processor
> >>> Stepping: 2
> >>> CPU MHz: 3842.459
> >>> BogoMIPS: 7684.91
> >>> Hypervisor vendor: KVM
> >>> Virtualization type: full
> >>> L1d cache: 256 KiB
> >>> L1i cache: 512 KiB
> >>> L2 cache: 4 MiB
> >>> L3 cache: 8 MiB
> >>> NUMA node0 CPU(s): 0-7
> >>> Vulnerability Itlb multihit: Not affected
> >>> Vulnerability L1tf: Not affected
> >>> Vulnerability Mds: Not affected
> >>> Vulnerability Meltdown: Not affected
> >>> Vulnerability Spec store bypass: Vulnerable
> >>> Vulnerability Spectre v1: Vulnerable: __user pointer sanitization
> >>> and usercopy barriers only; n o swapgs
> >>> barriers
> >>> Vulnerability Spectre v2: Vulnerable, STIBP: disabled
> >>> Vulnerability Srbds: Not affected
> >>> Vulnerability Tsx async abort: Not affected
> >>> Flags: fpu vme de pse tsc msr pae mce cx8 apic
> >>> sep mtrr pge mca cmov pat pse 36 clflush
> >>> mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rd
> >>> tscp lm rep_good nopl cpuid extd_apicid pni pclmulqdq ssse3
> >>> fma cx16 sse4_1 sse4_2 x2apic movbe popcnt
> >>> aes xsave avx f16c rdrand hyperviso r
> >>> lahf_lm cmp_legacy cr8_legacy abm sse4a misalignsse 3dnowprefetch o
> >>> svw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2
> >>> rdseed adx smap clfl ushopt sha_ni xsaveopt
> >>> xsavec xgetbv1 arat
> >>>
> >>> i have online one customer in this test server.
> >>>
> >>>
> >>>
> >>> On Sun, Dec 20, 2020, 17:33 Simon Chopin ***@***.***>
> >>> wrote:
> >>>
> >>>> Hi, thank you for testing this, I appreciate it very much.
> >>>>
> >>>> Could you share a bit more details about the error case? Is it on any
> >>>> client, or only some of them ? Are you running on amd64 or 32-bit
> x86?
> >>>>
> >>>> —
> >>>> You are receiving this because you commented.
> >>>> Reply to this email directly, view it on GitHub
> >>>> <#140 (comment)>,
> >>>> or unsubscribe
> >>>> <
> https://github.com/notifications/unsubscribe-auth/ADCWD5EYBI76OEIUIWNHB3TSVYKNJANCNFSM4OFPZQ4A
> >
> >>>> .
> >>>>
> >>>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#140 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAEQ4NOXTIZJJ5MUQ4LURPTSWN4SLANCNFSM4OFPZQ4A>
> .
>
|
|
what do these updates change in operation?
and whether these changes are already working?
…On Mon, Jan 11, 2021, 20:53 Simon Chopin ***@***.***> wrote:
Allright, this was a very silly mistake, and the reason I didn't catch it
is that my test script
failed silently even before getting to mounting a PPP.
That's what I get for trying to upstream my changes in small batches as
early as possible: each PR isn't as heavily
tested as it should :-/
On Thu, Dec 24, 2020 at 6:51 PM Simon Chopin ***@***.***>
wrote:
> I'll see what I can do after the holidays.
>
> Le jeu. 24 déc. 2020 à 18:43, micron10 ***@***.***> a
> écrit :
>
>> Simon if you havw fix for this i will test
>>
>> On Mon, Dec 21, 2020, 21:20 Martin Zaharinov ***@***.***>
wrote:
>>
>> > Do you have idea from where is come this bug ? and do you have fix for
>> > them ?
>> >
>> > На нд, 20.12.2020 г. в 18:54 ч. Martin Zaharinov ***@***.***>
>> > написа:
>> >
>> >> i try to change qemu cpu to intel SandyBridge and get same error
>> >>
>> >> after remove patch all work fine
>> >>
>> >> On Sun, Dec 20, 2020, 17:39 Martin Zaharinov ***@***.***>
>> wrote:
>> >>
>> >>> Hi
>> >>> Test on Proxmox latest version
>> >>>
>> >>> cpu is Ryzen 7 1800X
>> >>>
>> >>> in virtual machine is:
>> >>>
>> >>> lscpu
>> >>> Architecture: x86_64
>> >>> CPU op-mode(s): 32-bit, 64-bit
>> >>> Byte Order: Little Endian
>> >>> Address sizes: 40 bits physical, 48 bits virtual
>> >>> CPU(s): 8
>> >>> On-line CPU(s) list: 0-7
>> >>> Thread(s) per core: 1
>> >>> Core(s) per socket: 8
>> >>> Socket(s): 1
>> >>> NUMA node(s): 1
>> >>> Vendor ID: AuthenticAMD
>> >>> CPU family: 23
>> >>> Model: 1
>> >>> Model name: AMD EPYC Processor
>> >>> Stepping: 2
>> >>> CPU MHz: 3842.459
>> >>> BogoMIPS: 7684.91
>> >>> Hypervisor vendor: KVM
>> >>> Virtualization type: full
>> >>> L1d cache: 256 KiB
>> >>> L1i cache: 512 KiB
>> >>> L2 cache: 4 MiB
>> >>> L3 cache: 8 MiB
>> >>> NUMA node0 CPU(s): 0-7
>> >>> Vulnerability Itlb multihit: Not affected
>> >>> Vulnerability L1tf: Not affected
>> >>> Vulnerability Mds: Not affected
>> >>> Vulnerability Meltdown: Not affected
>> >>> Vulnerability Spec store bypass: Vulnerable
>> >>> Vulnerability Spectre v1: Vulnerable: __user pointer sanitization
>> >>> and usercopy barriers only; n o swapgs
>> >>> barriers
>> >>> Vulnerability Spectre v2: Vulnerable, STIBP: disabled
>> >>> Vulnerability Srbds: Not affected
>> >>> Vulnerability Tsx async abort: Not affected
>> >>> Flags: fpu vme de pse tsc msr pae mce cx8 apic
>> >>> sep mtrr pge mca cmov pat pse 36 clflush
>> >>> mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rd
>> >>> tscp lm rep_good nopl cpuid extd_apicid pni pclmulqdq ssse3
>> >>> fma cx16 sse4_1 sse4_2 x2apic movbe popcnt
>> >>> aes xsave avx f16c rdrand hyperviso r
>> >>> lahf_lm cmp_legacy cr8_legacy abm sse4a misalignsse 3dnowprefetch o
>> >>> svw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2
>> >>> rdseed adx smap clfl ushopt sha_ni xsaveopt
>> >>> xsavec xgetbv1 arat
>> >>>
>> >>> i have online one customer in this test server.
>> >>>
>> >>>
>> >>>
>> >>> On Sun, Dec 20, 2020, 17:33 Simon Chopin ***@***.***>
>> >>> wrote:
>> >>>
>> >>>> Hi, thank you for testing this, I appreciate it very much.
>> >>>>
>> >>>> Could you share a bit more details about the error case? Is it on
any
>> >>>> client, or only some of them ? Are you running on amd64 or 32-bit
>> x86?
>> >>>>
>> >>>> —
>> >>>> You are receiving this because you commented.
>> >>>> Reply to this email directly, view it on GitHub
>> >>>> <#140 (comment)
>,
>> >>>> or unsubscribe
>> >>>> <
>>
https://github.com/notifications/unsubscribe-auth/ADCWD5EYBI76OEIUIWNHB3TSVYKNJANCNFSM4OFPZQ4A
>> >
>> >>>> .
>> >>>>
>> >>>
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <#140 (comment)>, or
>> unsubscribe
>> <
https://github.com/notifications/unsubscribe-auth/AAEQ4NOXTIZJJ5MUQ4LURPTSWN4SLANCNFSM4OFPZQ4A
>
>> .
>>
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#140 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCWD5FAS25TITVN5G4B5B3SZNCJZANCNFSM4OFPZQ4A>
.
|
|
These aren't supposed to have an effect in operations, it's simply patches
to (in my view) improve the
code readability and make further work easier. The initial PR description
stated as much :-)
…On Mon, Jan 11, 2021 at 9:32 PM micron10 ***@***.***> wrote:
what do these updates change in operation?
and whether these changes are already working?
On Mon, Jan 11, 2021, 20:53 Simon Chopin ***@***.***> wrote:
> Allright, this was a very silly mistake, and the reason I didn't catch it
> is that my test script
> failed silently even before getting to mounting a PPP.
>
> That's what I get for trying to upstream my changes in small batches as
> early as possible: each PR isn't as heavily
> tested as it should :-/
>
> On Thu, Dec 24, 2020 at 6:51 PM Simon Chopin ***@***.***>
> wrote:
>
> > I'll see what I can do after the holidays.
> >
> > Le jeu. 24 déc. 2020 à 18:43, micron10 ***@***.***> a
> > écrit :
> >
> >> Simon if you havw fix for this i will test
> >>
> >> On Mon, Dec 21, 2020, 21:20 Martin Zaharinov ***@***.***>
> wrote:
> >>
> >> > Do you have idea from where is come this bug ? and do you have fix
for
> >> > them ?
> >> >
> >> > На нд, 20.12.2020 г. в 18:54 ч. Martin Zaharinov <
***@***.***>
> >> > написа:
> >> >
> >> >> i try to change qemu cpu to intel SandyBridge and get same error
> >> >>
> >> >> after remove patch all work fine
> >> >>
> >> >> On Sun, Dec 20, 2020, 17:39 Martin Zaharinov ***@***.***>
> >> wrote:
> >> >>
> >> >>> Hi
> >> >>> Test on Proxmox latest version
> >> >>>
> >> >>> cpu is Ryzen 7 1800X
> >> >>>
> >> >>> in virtual machine is:
> >> >>>
> >> >>> lscpu
> >> >>> Architecture: x86_64
> >> >>> CPU op-mode(s): 32-bit, 64-bit
> >> >>> Byte Order: Little Endian
> >> >>> Address sizes: 40 bits physical, 48 bits virtual
> >> >>> CPU(s): 8
> >> >>> On-line CPU(s) list: 0-7
> >> >>> Thread(s) per core: 1
> >> >>> Core(s) per socket: 8
> >> >>> Socket(s): 1
> >> >>> NUMA node(s): 1
> >> >>> Vendor ID: AuthenticAMD
> >> >>> CPU family: 23
> >> >>> Model: 1
> >> >>> Model name: AMD EPYC Processor
> >> >>> Stepping: 2
> >> >>> CPU MHz: 3842.459
> >> >>> BogoMIPS: 7684.91
> >> >>> Hypervisor vendor: KVM
> >> >>> Virtualization type: full
> >> >>> L1d cache: 256 KiB
> >> >>> L1i cache: 512 KiB
> >> >>> L2 cache: 4 MiB
> >> >>> L3 cache: 8 MiB
> >> >>> NUMA node0 CPU(s): 0-7
> >> >>> Vulnerability Itlb multihit: Not affected
> >> >>> Vulnerability L1tf: Not affected
> >> >>> Vulnerability Mds: Not affected
> >> >>> Vulnerability Meltdown: Not affected
> >> >>> Vulnerability Spec store bypass: Vulnerable
> >> >>> Vulnerability Spectre v1: Vulnerable: __user pointer sanitization
> >> >>> and usercopy barriers only; n o swapgs
> >> >>> barriers
> >> >>> Vulnerability Spectre v2: Vulnerable, STIBP: disabled
> >> >>> Vulnerability Srbds: Not affected
> >> >>> Vulnerability Tsx async abort: Not affected
> >> >>> Flags: fpu vme de pse tsc msr pae mce cx8 apic
> >> >>> sep mtrr pge mca cmov pat pse 36 clflush
> >> >>> mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rd
> >> >>> tscp lm rep_good nopl cpuid extd_apicid pni pclmulqdq ssse3
> >> >>> fma cx16 sse4_1 sse4_2 x2apic movbe popcnt
> >> >>> aes xsave avx f16c rdrand hyperviso r
> >> >>> lahf_lm cmp_legacy cr8_legacy abm sse4a misalignsse 3dnowprefetch
o
> >> >>> svw topoext vmmcall fsgsbase bmi1 avx2 smep bmi2
> >> >>> rdseed adx smap clfl ushopt sha_ni xsaveopt
> >> >>> xsavec xgetbv1 arat
> >> >>>
> >> >>> i have online one customer in this test server.
> >> >>>
> >> >>>
> >> >>>
> >> >>> On Sun, Dec 20, 2020, 17:33 Simon Chopin <
***@***.***>
> >> >>> wrote:
> >> >>>
> >> >>>> Hi, thank you for testing this, I appreciate it very much.
> >> >>>>
> >> >>>> Could you share a bit more details about the error case? Is it on
> any
> >> >>>> client, or only some of them ? Are you running on amd64 or 32-bit
> >> x86?
> >> >>>>
> >> >>>> —
> >> >>>> You are receiving this because you commented.
> >> >>>> Reply to this email directly, view it on GitHub
> >> >>>> <
#140 (comment)
> >,
> >> >>>> or unsubscribe
> >> >>>> <
> >>
>
https://github.com/notifications/unsubscribe-auth/ADCWD5EYBI76OEIUIWNHB3TSVYKNJANCNFSM4OFPZQ4A
> >> >
> >> >>>> .
> >> >>>>
> >> >>>
> >>
> >> —
> >> You are receiving this because you authored the thread.
> >> Reply to this email directly, view it on GitHub
> >> <#140 (comment)>,
or
> >> unsubscribe
> >> <
>
https://github.com/notifications/unsubscribe-auth/AAEQ4NOXTIZJJ5MUQ4LURPTSWN4SLANCNFSM4OFPZQ4A
> >
> >> .
> >>
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#140 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ADCWD5FAS25TITVN5G4B5B3SZNCJZANCNFSM4OFPZQ4A
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#140 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEQ4NITPZDBIZA5P5YOYDTSZNN63ANCNFSM4OFPZQ4A>
.
|
|
Dear @laarmen, Can you open a PR at "good" place: Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of some work on the PPPoE subsystem regarding the configuration reload, I made various modifications to the codebase that are only loosely related. This PR is the first of several for these changes.
These patches shouldn't change anything to the behavior of the program, and are only aimed at easing the development.