-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Fix building on Linux #2277
base: master
Are you sure you want to change the base?
Conversation
Thanks, but I tried your PR and it's still failing for me. Can you have a look at my comment in #2275 regarding building with gcc-14? |
Yeah, there are multiple issues, this only fixes the testing-specific one. As far as I saw the cxxopts submodule is quite old, and might already have a fix in never versions. I did a cheap workaround by commenting out this line: Line 43 in 3d30b2e
Other than that and premake5 not getting found I had no issues. |
Thanks. What compiler are you using? I'm sure there's a way to force gcc-13 to avoid the issue I mentioned (perhaps you know off the top?) so I can at least get it to build with your PR. |
Xenia seems to build with clang by default, so clang 18.1.8. |
So has anything happened as far as fixing linux builds? |
I just wanted to chime in that this PR and my pr (#2293) does fix the remaining Linux build issues. The issue with the |
After looking at the other PRs it looks like this issues has actually already been fixed, it just hasn't been merged in yet. This change is actually identical to PR #2227. |
This fixes building Xenia on my Arch Linux machine. Without these changes, building throws the following error:
I also had to modify the build system to find my system's version of premake5, I can PR that as well if desired.