Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Reset CameraControl default values when followPointer config is dynamically changed #1423

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Kurtil
Copy link
Contributor

@Kurtil Kurtil commented Mar 26, 2024

Use case:

  • I added a UI button to switch cameraControl.followPointer on and off (true/ false).
    => The dolly rate when followPointer is false is not consistent.

Steps to reproduce the issue:

  • dolly using the mouse wheel on an object when cameraControl.followPointer is true. (it sets the dollyDistFactor to a computed value)
  • change the cameraControl.followPointer to false.
    => the distance from the previous object influences the dolly rate because dollyDistFactor is not reset to 1.

@xeolabs xeolabs added this to the 2.6.0 milestone Mar 26, 2024
@xeolabs xeolabs changed the title Reset cameraControl default values when followPointer config is dynamically changed [FIX] Reset cameraControl default values when followPointer config is dynamically changed Mar 26, 2024
@xeolabs xeolabs merged commit 5b62730 into xeokit:master Mar 26, 2024
1 of 2 checks passed
@xeolabs xeolabs changed the title [FIX] Reset cameraControl default values when followPointer config is dynamically changed [FIX] Reset CameraControl default values when followPointer config is dynamically changed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants