Skip to content

Commit

Permalink
Reduce minimum version even more, compile with java 17 on workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
xirreal committed May 3, 2024
1 parent 141927f commit 3742404
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 11 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@ jobs:
build:
strategy:
matrix:
# Use these Java versions
java: [
21, # Current Java LTS
17,
]
runs-on: ubuntu-22.04
steps:
Expand All @@ -30,7 +29,7 @@ jobs:
- name: build
run: ./gradlew build
- name: capture build artifacts
if: ${{ matrix.java == '21' }} # Only upload artifacts built from latest java
if: ${{ matrix.java == '17' }}
uses: actions/upload-artifact@v4
with:
name: Artifacts
Expand Down
13 changes: 6 additions & 7 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,14 @@ org.gradle.jvmargs=-Xmx1G
org.gradle.parallel=true

# Fabric Properties
# check these on https://fabricmc.net/develop
minecraft_version=1.20.6
yarn_mappings=1.20.6+build.1
loader_version=0.15.10
# I chose 1.18.2 because it uses Java 17.
minecraft_version=1.18.2
yarn_mappings=1.18.2+build.4
loader_version=0.15.6

# Mod Properties
mod_version=1.0.0
mod_version=1.0.1
maven_group=dev.xirreal
archives_base_name=nsight-loader

# Dependencies
fabric_version=0.97.8+1.20.6
fabric_version=0.77.0+1.18.2
2 changes: 1 addition & 1 deletion src/main/resources/fabric.mod.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
]
},
"depends": {
"fabricloader": ">=0.15.10",
"fabricloader": ">=0.15.0",
"minecraft": "^1.18.2",
"java": ">=17"
}
Expand Down

0 comments on commit 3742404

Please sign in to comment.