Added diagrams generated with Cloudnet TOSCA toolbox #50
Conversation
anzoman
added
enhancement
There was a problem hiding this comment.
@philippemerle thanks for pushing #50 forward and generating these diagrams.
I left a comment about this here: #48 (comment).
| <map id="tosca-intrinsic-functions-service-uml2-class-diagram_map" name="tosca-intrinsic-functions-service-uml2-class-diagram_map"> | ||
| <area shape="rect" id="id1" href="'a'," title="'a'," alt="" coords="565,179,717,192"/> | ||
| </map> |
There was a problem hiding this comment.
Hmm, why is this file different than the others?
| # Check that the CLOUDNET_BINDIR environment variable is set correctly. | ||
| if [ ! -f ${CLOUDNET_BINDIR}/cloudnet_rc.sh ] | ||
| then | ||
| echo "The CLOUDNET_BINDIR environment variable is not set correctly!" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
This script can be executed if the user has already installed Cloudnet TOSCA toolbox, right? It would be nice to have also the installation part here in this script.
| @@ -0,0 +1,26 @@ | |||
| ###################################################################### | |||
There was a problem hiding this comment.
I would rename this folder to .cloudnet-tosca-toolbox for being clearer. It's important that this directory name starts with the dot (.) to keep it hidden. This is needed because xOpera examples are already separated into folders and we cannot have a folder for generating diagrams on the same level.
| rm diagrams/*-workflow-diagram.plantuml | ||
|
|
||
| # Generate UML2 diagrams. | ||
| generate_uml2_diagrams diagrams/*.plantuml |
There was a problem hiding this comment.
I'd also rather see that each diagram would be separated the folder that contains the corresponding example.
|
Closing due to inactivity and can be reopened in the future. |
Related to #48