Image support #79
Open
Image support #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 25, 2019 14:23
- Only supports adding an image bounded to a single cell - No test cases beyond example.exs - Not much in the way of docs - The relationship between drawing and image could be cleaner - example image downloaded from https://pixabay.com/en/ladybug-insect-beetle-nature-3475779/ licenced CC0 Creative Commons
example.xlsx now opens cleanly in Excel for Mac
|
@proactively looks like @xou merged a bunch of other PRs now, so new conflicts arose. |
|
Really sorry about this, normally I would try to figure this out myself but I currently don't have the spare cycles :/ |
|
I will take a look. Not this week though as I’m far from my computer
Sean
… On 24 Mar 2019, at 02:00, Nikolai Weh ***@***.***> wrote:
Really sorry about this, normally I would try to figure this out myself but I currently don't have the spare cycles :/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Closed
xou
force-pushed
the
master
branch
3 times, most recently
from
e7bdfd0 to
68acd8d
Compare
|
Is there any news regarding this PR? |
|
That would be a great addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for taking so long over this.
This PR is for a version that doesn't depend on the whole codebase being mix formatted so you can deal with that another time.