Skip to content

Commit

Permalink
XWIKI-22173: Underline the edit this page link (#3124)
Browse files Browse the repository at this point in the history
* Updated the translations for the page not exist message.
* Refactored some of the style related to inline link underlining in general.less
  • Loading branch information
Sereza7 authored Jul 23, 2024
1 parent 2eeb08c commit c670555
Show file tree
Hide file tree
Showing 40 changed files with 44 additions and 41 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ body {

&.preference-underlining-only-inline-links {
// Define an inline link mixin
.inline-link {
text-decoration: underline;
}
.not-inline-link {
text-decoration: none;
// Make sure we don't take over the default behaviour on hover with too much specificity.
Expand All @@ -156,7 +159,7 @@ body {

// Main rule for the content
#xwikicontent a {
text-decoration: underline;
.inline-link();
}

// UIs where we want to underline outside of content.
Expand All @@ -165,7 +168,7 @@ body {
.commentauthor // Similarly to the page last modificator, we want to underline comment authors.
{
& a {
text-decoration: underline;
.inline-link();
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,7 @@ core.menu.toggleNavigation=Toggle navigation
core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}">edit this page</a> to create it.
core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}" class="force-underline">edit this page</a> to create it.

core.viewers.comments.title=Comments on <a href="{1}">{0}</a>
core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.shortcuts.edit.saveandview=Alt+S
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}">edit this page</a> to create it.
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}" class="force-underline">edit this page</a> to create it.

### Missing: core.viewers.comments.title=Comments on <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.menu.watch=Observa
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Podeu <a href="{0}">editar aquesta p\u00E0gina</a> per a crear-la.
core.viewers.content.doesnotexists.edittocreate=Podeu <a href="{0}" class="force-underline">editar aquesta p\u00E0gina</a> per a crear-la.

core.viewers.comments.title=Comentaris a <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.menu.watch=Sledovat
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=M\u016F\u017Eete <a href="{0}">kliknout sem</a> a str\u00E1nku vytvo\u0159it.
core.viewers.content.doesnotexists.edittocreate=M\u016F\u017Eete <a href="{0}" class="force-underline">kliknout sem</a> a str\u00E1nku vytvo\u0159it.

core.viewers.comments.title=Koment\u00E1\u0159e k <a href="{1}">{0}</a>
core.viewers.comments.permalink=Trval\u00FD odkaz
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.menu.watch=Overv\u00E5g
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Du kan <a href="{0}">redigere siden</a> og dermed oprette den.
core.viewers.content.doesnotexists.edittocreate=Du kan <a href="{0}" class="force-underline">redigere siden</a> og dermed oprette den.

core.viewers.comments.title=Kommentar til <a href="{1}">{0}</a>
core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ core.menu.toggleNavigation=Navigation ein-/ausblenden
core.menu.toggleDropdown=Dropdown ein-/ausblenden

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Sie k\u00F6nnen <a href="{0}">diese Seite bearbeiten</a> um sie zu erstellen.
core.viewers.content.doesnotexists.edittocreate=Sie k\u00F6nnen <a href="{0}" class="force-underline">diese Seite bearbeiten</a> um sie zu erstellen.
core.viewers.comments.title=Kommentare f\u00FCr <a href="{1}">{0}</a>
core.viewers.comments.permalink=Permalink
core.viewers.comments.permalink.goto=Gehe zu permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.shortcuts.edit.saveandview=Alt+S
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}">edit this page</a> to create it.
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}" class="force-underline">edit this page</a> to create it.

### Missing: core.viewers.comments.title=Comments on <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ core.menu.toggleNavigation=Cambiar navegaci\u00F3n
core.menu.toggleDropdown=Cambiar desplegable

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Puede <a href="{0}">editar esta p\u00E1gina</a> para crearla.
core.viewers.content.doesnotexists.edittocreate=Puede <a href="{0}" class="force-underline">editar esta p\u00E1gina</a> para crearla.
core.viewers.comments.title=Comentarios en <a href="{1}">{0}</a>
core.viewers.comments.permalink=Enlace permanente
core.viewers.comments.permalink.goto=Ir a permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.shortcuts.edit.saveandview=Alt+S
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}">edit this page</a> to create it.
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}" class="force-underline">edit this page</a> to create it.

### Missing: core.viewers.comments.title=Comments on <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ core.menu.toggleNavigation=Ouvrir/Fermer la navigation
core.menu.toggleDropdown=Ouvrir/Fermer le menu d\u00E9roulant

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Vous pouvez <a href="{0}">cr\u00E9er cette page</a>.
core.viewers.content.doesnotexists.edittocreate=Vous pouvez <a href="{0}" class="force-underline">cr\u00E9er cette page</a>.
core.viewers.comments.title=Commentaires sur <a href="{1}">{0}</a>
core.viewers.comments.permalink=Lien permanent
core.viewers.comments.permalink.goto=Ouvrir le Lien permanent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ core.menu.watch=Observar
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Pode vostede <a href\="{0}">editar esta p\u00E1xina</a> para creala
core.viewers.content.doesnotexists.edittocreate=Pode vostede <a href\="{0}" class="force-underline">editar esta p\u00E1xina</a> para creala
core.viewers.comments.title=Comentarios sobre <a href\="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
### Missing: core.viewers.comments.permalink.goto=Go to permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -993,7 +993,7 @@ core.menu.watch=\u0926\u0947\u0916\u0947\u0902
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=\u0906\u092A <a href\="{0}">\u0907\u0938 \u092A\u0943\u0937\u094D\u0920 \u0915\u093E \u0928\u093F\u0930\u094D\u092E\u093E\u0923 \u0915\u0930\u0928\u0947 \u0915\u0947 \u0932\u093F\u090F \u0907\u0938\u0947 \u0938\u0902\u092A\u093E\u0926\u093F\u0924 \u0915\u0930 \u0938\u0915\u0924\u0947 \u0939\u0948\u0902.</a>
core.viewers.content.doesnotexists.edittocreate=\u0906\u092A <a href\="{0}" class="force-underline">\u0907\u0938 \u092A\u0943\u0937\u094D\u0920 \u0915\u093E \u0928\u093F\u0930\u094D\u092E\u093E\u0923 \u0915\u0930\u0928\u0947 \u0915\u0947 \u0932\u093F\u090F \u0907\u0938\u0947 \u0938\u0902\u092A\u093E\u0926\u093F\u0924 \u0915\u0930 \u0938\u0915\u0924\u0947 \u0939\u0948\u0902.</a>
### Missing: core.viewers.comments.title=Comments on <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
### Missing: core.viewers.comments.permalink.goto=Go to permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.menu.toggleNavigation=Omogu\u0107i/onemogu\u0107i navigaciju
core.menu.toggleDropdown=Uklju\u010Dite/isklju\u010Dite padaju\u0107e

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Mo\u017Eete <a href="{0}">urediti ovu stranicu</a> da biste je izradili.
core.viewers.content.doesnotexists.edittocreate=Mo\u017Eete <a href="{0}" class="force-underline">urediti ovu stranicu</a> da biste je izradili.

core.viewers.comments.title=Komentari na <a href="{1}">{0}</a>
core.viewers.comments.permalink=Permanentna poveznica
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.menu.copy=M\u00E1sol\u00E1s
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}">edit this page</a> to create it.
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}" class="force-underline">edit this page</a> to create it.

### Missing: core.viewers.comments.title=Comments on <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.shortcuts.edit.saveandview=Alt+S
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}">edit this page</a> to create it.
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}" class="force-underline">edit this page</a> to create it.

### Missing: core.viewers.comments.title=Comments on <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.menu.watch=Sorveglia
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=\u00C8 possibile <a href="{0}">modificare questa pagina</a> per crearla.
core.viewers.content.doesnotexists.edittocreate=\u00C8 possibile <a href="{0}" class="force-underline">modificare questa pagina</a> per crearla.

core.viewers.comments.title=Commenti su <a href="{1}">{0}</a>
core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,7 @@ core.menu.toggleNavigation=\u30CA\u30D3\u30B2\u30FC\u30B7\u30E7\u30F3\u3092\u520
core.menu.toggleDropdown=\u30C9\u30ED\u30C3\u30D7\u30C0\u30A6\u30F3\u3092\u5207\u308A\u66FF\u3048\u308B

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=<a href="{0}">\u3053\u306E\u30DA\u30FC\u30B8\u3092\u7DE8\u96C6</a>\u3057\u3066\u4F5C\u6210\u3067\u304D\u307E\u3059\u3002
core.viewers.content.doesnotexists.edittocreate=<a href="{0}" class="force-underline">\u3053\u306E\u30DA\u30FC\u30B8\u3092\u7DE8\u96C6</a>\u3057\u3066\u4F5C\u6210\u3067\u304D\u307E\u3059\u3002
core.viewers.comments.title=<a href="{1}">{0}</a>\u306E\u30B3\u30E1\u30F3\u30C8
core.viewers.comments.permalink=\u30D1\u30FC\u30DE\u30EA\u30F3\u30AF
core.viewers.comments.permalink.goto=\u30D1\u30FC\u30DE\u30EA\u30F3\u30AF\u306B\u884C\u304F
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.shortcuts.edit.saveandview=Alt+S
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}">edit this page</a> to create it.
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}" class="force-underline">edit this page</a> to create it.

### Missing: core.viewers.comments.title=Comments on <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.shortcuts.edit.saveandview=Alt+S
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}">edit this page</a> to create it.
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}" class="force-underline">edit this page</a> to create it.

### Missing: core.viewers.comments.title=Comments on <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ core.menu.toggleNavigation=navigation \uC804\uD658
core.menu.toggleDropdown=dropdown \uC804\uD658

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=<a href="{0}">\uC774 \uD398\uC774\uC9C0\uB97C \uD3B8\uC9D1</a> \uD558\uC5EC \uC0DD\uC131\uD560 \uC218 \uC788\uC2B5\uB2C8\uB2E4.
core.viewers.content.doesnotexists.edittocreate=<a href="{0}" class="force-underline">\uC774 \uD398\uC774\uC9C0\uB97C \uD3B8\uC9D1</a> \uD558\uC5EC \uC0DD\uC131\uD560 \uC218 \uC788\uC2B5\uB2C8\uB2E4.
core.viewers.comments.title=<a href="{1}">{0}</a>\uC758 \uB313\uAE00
core.viewers.comments.permalink=Permalink
core.viewers.comments.permalink.goto=permalink\uB85C \uAC00\uAE30
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.shortcuts.edit.saveandview=Alt+S
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}">edit this page</a> to create it.
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}" class="force-underline">edit this page</a> to create it.

### Missing: core.viewers.comments.title=Comments on <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.menu.toggleNavigation=P\u0101rsl\u0113gt navig\u0101ciju
core.menu.toggleDropdown=P\u0101rsl\u0113gt nolai\u017Eamo sarakstu

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=J\u016Bs varat <a href="{0}">main\u012Bt \u0161o lapu</a>, lai to izveidotu.
core.viewers.content.doesnotexists.edittocreate=J\u016Bs varat <a href="{0}" class="force-underline">main\u012Bt \u0161o lapu</a>, lai to izveidotu.

core.viewers.comments.title=Koment\u0101ri par <a href="{1}">{0}</a>
core.viewers.comments.permalink=Saite
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.shortcuts.edit.saveandview=Alt+S
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}">edit this page</a> to create it.
### Missing: core.viewers.content.doesnotexists.edittocreate=You can <a href="{0}" class="force-underline">edit this page</a> to create it.

### Missing: core.viewers.comments.title=Comments on <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -993,7 +993,7 @@ core.menu.toggleNavigation=Wissel navigatie
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=U kunt <a href\="{0}">deze pagina wijzigen</a> om hem te maken.
core.viewers.content.doesnotexists.edittocreate=U kunt <a href\="{0}" class="force-underline">deze pagina wijzigen</a> om hem te maken.
core.viewers.comments.title=Opmerkingen bij <a href\="{1}">{0}</a>
core.viewers.comments.permalink=Permalink
core.viewers.comments.permalink.goto=Ga naar permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -999,7 +999,7 @@ core.menu.toggleNavigation=Vis/skjul navigasjon
core.menu.toggleDropdown=Vis/skjul nedtrekksmeny

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Du kan <a href="{0}">redigere denne siden</a> for \u00E5 opprette den.
core.viewers.content.doesnotexists.edittocreate=Du kan <a href="{0}" class="force-underline">redigere denne siden</a> for \u00E5 opprette den.
core.viewers.comments.title=Kommentarer p\u00E5 <a href="{1}">{0}</a>
core.viewers.comments.permalink=Permalenke
core.viewers.comments.permalink.goto=G\u00E5 til permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ core.menu.toggleNavigation=Menu
core.menu.toggleDropdown=Prze\u0142\u0105cz list\u0119 rozwijan\u0105

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Mo\u017Cesz <a href="{0}">edytowa\u0107 t\u0119 stron\u0119</a> by stworzy\u0107 j\u0105.
core.viewers.content.doesnotexists.edittocreate=Mo\u017Cesz <a href="{0}" class="force-underline">edytowa\u0107 t\u0119 stron\u0119</a> by stworzy\u0107 j\u0105.

core.viewers.comments.title=Komentarze do <a href="{1}">{0}</a>
core.viewers.comments.permalink=Odno\u015Bnik bezpo\u015Bredni
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -999,7 +999,7 @@ core.menu.watch=Monitorar
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Voc\u00EA pode <a href="{0}">editar essa p\u00E1gina</a> para cri\u00E1-la.
core.viewers.content.doesnotexists.edittocreate=Voc\u00EA pode <a href="{0}" class="force-underline">editar essa p\u00E1gina</a> para cri\u00E1-la.
core.viewers.comments.title=Coment\u00E1rios de <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
### Missing: core.viewers.comments.permalink.goto=Go to permalink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ core.menu.toggleNavigation=Alternar navega\u00E7\u00E3o
core.menu.toggleDropdown=Alternar lista suspensa

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Voc\u00EA pode <a href\="{0}">editar essa p\u00E1gina</a> para cri\u00E1-la.
core.viewers.content.doesnotexists.edittocreate=Voc\u00EA pode <a href\="{0}" class="force-underline">editar essa p\u00E1gina</a> para cri\u00E1-la.
core.viewers.comments.title=Coment\u00E1rios em <a href\="{1}">{0}</a>
core.viewers.comments.permalink=Link permanente
core.viewers.comments.permalink.goto=V\u00E1 para o link permanente
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -993,7 +993,7 @@ core.menu.watch=Monitorizare
### Missing: core.menu.toggleDropdown=Toggle dropdown

### Messages for the various document viewers (history, attachments, info...)
core.viewers.content.doesnotexists.edittocreate=Pute\u0163i <a href="{0}">edita aceast\u0103 pagin\u0103</a> pentru a \u00EEl crea.
core.viewers.content.doesnotexists.edittocreate=Pute\u0163i <a href="{0}" class="force-underline">edita aceast\u0103 pagin\u0103</a> pentru a \u00EEl crea.
core.viewers.comments.title=Comentarii pentru <a href="{1}">{0}</a>
### Missing: core.viewers.comments.permalink=Permalink
### Missing: core.viewers.comments.permalink.goto=Go to permalink
Expand Down
Loading

0 comments on commit c670555

Please sign in to comment.