XWIKI-21773: Admin section: make the WYSIWYG section pass webstandard tests #2794
Conversation
… tests * Fixed the input labels Note: This change successfully passes webstandards for section=WYSIWYG. It's not the same fix as XWIKI-21523 because we can't rely on javascript enhancements of the form, and we need to provide the label for the input that gets hidden by javascript.
… tests * Removed the comment from the test for WYSIWYG
| @@ -218,7 +218,7 @@ | |||
|
|
|||
| #macro (displayCKEditorConfigProperty $configDoc $propName $action) | |||
| <dt> | |||
| <label>$configDoc.displayPrettyName($propName)</label> | |||
| <label for="CKEditor.ConfigClass_0_${propName}">$configDoc.displayPrettyName($propName)</label> | |||
There was a problem hiding this comment.
You're sure the xobject is always at index 0 here?
There was a problem hiding this comment.
From what I could see, this is always the first object with this name that gets displayed, so it's always indexed 0.
I don't think there's much variation in this UI.
Similar to #2642 (comment)
There was a problem hiding this comment.
this is always the first object with this name that gets displayed, so it's always indexed 0.
First object doesn't necessarily mean indexed at 0. e.g. you can add two xobject in a document, and then remove the first one. If you try that you'll see that now the first xobject in the document is indexed at 1.
There was a problem hiding this comment.
Fixed in aaf80f3 👍
Running mvn clean install -f xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/xwiki-platform-distribution-flavor-test-webstandards -Dxwiki.test.startXWiki=false again only highlighted violations unrelated to the objectives of this PR. Manual tests looked good too:
… tests * Replaced the hard coded number value with a more robust computed one.
… tests (xwiki#2794) * Fixed the input labels * Removed the comment from the test for WYSIWYG * Replaced the hard coded number value with a more robust computed one.
… tests (xwiki#2794) * Fixed the input labels * Removed the comment from the test for WYSIWYG * Replaced the hard coded number value with a more robust computed one.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21773
Changes
Description
Clarifications
Executed Tests
mvn clean install -f xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/xwiki-platform-distribution-flavor-test-webstandards -Dxwiki.test.startXWiki=falseExpected merging strategy