XWIKI-21880: Cannot delete user defined filters #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor DefaultNotificationFilterPreferenceManager to never throw
immediately an exception thrown by a provider, but to only do it if
all providers failed
* Provide a new test covering this behaviour
surli
added
the
backport stable-15.10.x
surli
commented
Feb 13, 2024
...ava/org/xwiki/notifications/filters/internal/DefaultNotificationFilterPreferenceManager.java
Show resolved
Hide resolved
* Small test improvment
tmortagne
reviewed
Feb 13, 2024
...ava/org/xwiki/notifications/filters/internal/DefaultNotificationFilterPreferenceManager.java
Outdated
Show resolved
Hide resolved
* Improve a bit the logic to use standard exception if there's only
one provider
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Refactor DefaultNotificationFilterPreferenceManager to never throw
immediately an exception thrown by a provider, but to only do it if
all providers failed
* Provide a new test covering this behaviour
* Small test improvment
* Improve a bit the logic to use standard exception if there's only
one provider
(cherry picked from commit 103650d)
surli
added a commit
that referenced
this pull request
Feb 13, 2024
* Refactor DefaultNotificationFilterPreferenceManager to never throw
immediately an exception thrown by a provider, but to only do it if
all providers failed
* Provide a new test covering this behaviour
* Small test improvment
* Improve a bit the logic to use standard exception if there's only
one provider
(cherry picked from commit 103650d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21880
Changes
Description
Clarifications
Use same pattern in every method of DefaultNotificationFilterPreferenceManager to always check if at least one provider managed to process a call, and to only throw the exception if all of them failed.
Executed Tests
Run of
mvn clean install -Pqualityin modulexwiki-platform-notification-filters-api.Expected merging strategy