XWIKI-9759: The javascript for the "Display annotation by default" feature gets cached too eagerly

[manuelleduc]

Jira URL

https://jira.xwiki.org/browse/XWIKI-9759

Note: as I wrapped a large piece of code in a require it is advised to review with Hide whitespace=true.

Changes

Description

• Remove parse=true from AnnotationCode.Script, as a consequence:
  • All the translations are now loaded using a l10n Javascript module
  • the dependency to fast-diff is declared using a new org.xwiki.platform.requirejs.module UIX
  • the config is provided through a org.xwiki.platform.template.header.after UIX, providing the config in the form of serialized json in a #annotation-config script tag
  • the url to AnnotationCode.Settings in view mode is now provided to the config instead of being computed in the jsx
  • all the config initially computed in Velocity at the top of the jsx are now accessed from the config

Executed Tests

mvn clean install \
  -pl :xwiki-platform-annotation-ui \
  -f xwiki-platform-core/xwiki-platform-annotation \
  -amd \
  -Pquality,integration-tests,docker

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • N/A

[mflorea]

Why keep the anonymous function? Its purpose was to create a namespace so that we don't pollute the global namespace, but the require callback function does this now.

[manuelleduc]

But don't we still want to expose XWiki.Annotation publicly?

[manuelleduc]

ok, now I get what you mean, indeed I can drop a level of wrapping. Thanks!