Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWIKI-17702: Annotation anchor not working when "show annotations" is off #2921

Merged
merged 5 commits into from
Feb 29, 2024
Merged

XWIKI-17702: Annotation anchor not working when "show annotations" is off #2921

merged 5 commits into from
Feb 29, 2024

Conversation

manuelleduc
Copy link
Contributor

@manuelleduc manuelleduc commented Feb 22, 2024 •
edited
Loading

Jira URL

https://jira.xwiki.org/browse/XWIKI-17702

Changes

Description

  • Listen for the clicks on the quotes of annotations in the comments sections.
    • fetch the annotations if needed
    • make the annotations visible
    • go to the anchor

TODO:

  • add functional test

Executed Tests

mvn clean install \
  -Pquality,integration-tests,docker \
  -pl :xwiki-platform-annotation-test-docker,:xwiki-platform-annotation-test-pageobjects,:xwiki-platform-test-ui

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • stable-15.10.x
    • stable-16.1.x

@manuelleduc manuelleduc added backport stable-15.10.x Used for automatic backport to 15.10.x branch. backport stable-16.1.x labels Feb 22, 2024
@manuelleduc manuelleduc marked this pull request as ready for review February 23, 2024 09:43
@manuelleduc manuelleduc merged commit 26ffd44 into xwiki:master Feb 29, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 29, 2024
@manuelleduc @github-actions
XWIKI-17702: Annotation anchor not working when "show annotations" is…
8e0c951 
… off (#2921)

(cherry picked from commit 26ffd44)
@github-actions github-actions bot mentioned this pull request Feb 29, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Feb 29, 2024
@manuelleduc @github-actions
XWIKI-17702: Annotation anchor not working when "show annotations" is…
45a412f 
… off (#2921)

(cherry picked from commit 26ffd44)
@github-actions github-actions bot mentioned this pull request Feb 29, 2024
Merged
manuelleduc added a commit that referenced this pull request Feb 29, 2024
@github-actions @manuelleduc
XWIKI-17702: Annotation anchor not working when "show annotations" is…
a75abd8 
… off (#2921) (#2943)

(cherry picked from commit 26ffd44)

Co-authored-by: Manuel Leduc <manuel.leduc@xwiki.com>
manuelleduc added a commit that referenced this pull request Feb 29, 2024
@github-actions @manuelleduc
XWIKI-17702: Annotation anchor not working when "show annotations" is…
f0125ec 
… off (#2921) (#2944)

(cherry picked from commit 26ffd44)

Co-authored-by: Manuel Leduc <manuel.leduc@xwiki.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surli surli surli left review comments

Assignees
No one assigned
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuelleduc @surli