XWIKI-21809: ClassCastException in DefaultEventConverterManager on a cluster environment #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cluster environment
* Some task output is Optional and we never want the Optional in the
notification data: we do want what the Optional contains.
surli
added
backport stable-15.10.x
tmortagne
reviewed
Feb 26, 2024
...tstream-api/src/main/java/org/xwiki/eventstream/internal/AbstractAsynchronousEventStore.java
Outdated
Show resolved
Hide resolved
…cluster environment
* Prevent entirely notification to be sent if output is Optional and
return is empty
tmortagne
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21809
Changes
Description
Some task output is Optional and we never want the Optional in the notification data: we do want what the Optional contains.
This PR provides a test to expose the bug and a naive fix.
Clarifications
I've not been able to provide a better fix as it would involve breaking APIs to not return Optional. On the long run I'm not sure it was really necessary to have Optional for the APIs here: it's basically only used to support backward compatibility with the legacy store AFAICS, so the Optional is never empty with the new store...
Executed Tests
mvn clean install -Pqualityonxwiki-platform-eventstreamExpected merging strategy