XWIKI-21971: No options when using LiveData with a LevelsClass column #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Provide a list of maps of label / values in case of LevelsClass
* Provide equals/hashcode/tostring method in
LiveDataPropertyDescriptor
* Improve test to rely on LiveDataPropertyDescriptor objects instead
of relying on JSON serialization
surli
added
the
backport stable-15.10.x
surli
commented
Mar 14, 2024
| String expectedJSON = | ||
| "[" + getExpectedDocPropsJSON() + "," + expectedClassProps.toString().replace('\'', '"') + "]"; | ||
| assertEquals(expectedJSON, this.objectMapper.writeValueAsString(properties)); | ||
| assertEquals(List.of(descriptor0, descriptor1, descriptor2, descriptor3, descriptor4), properties); |
There was a problem hiding this comment.
As discussed on the chat, I've refactored the test to use objects instead of JSON serialization to avoid issues with order of parameters.
There was a problem hiding this comment.
Thanks for refactoring this!
manuelleduc
reviewed
Mar 14, 2024
...xwiki-platform-livedata-api/src/main/java/org/xwiki/livedata/LiveDataPropertyDescriptor.java
Show resolved
Hide resolved
manuelleduc
reviewed
Mar 14, 2024
...xwiki-platform-livedata-api/src/main/java/org/xwiki/livedata/LiveDataPropertyDescriptor.java
Outdated
Show resolved
Hide resolved
manuelleduc
reviewed
Mar 14, 2024
...xwiki-platform-livedata-api/src/main/java/org/xwiki/livedata/LiveDataPropertyDescriptor.java
Outdated
Show resolved
Hide resolved
manuelleduc
reviewed
Mar 14, 2024
...able/src/main/java/org/xwiki/livedata/internal/livetable/LiveTableLiveDataPropertyStore.java
Outdated
Show resolved
Hide resolved
manuelleduc
approved these changes
Mar 14, 2024
* Minor fixes after review
github-actions bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
…#2982) * Provide a list of maps of label / values in case of LevelsClass * Provide equals/hashcode/tostring method in LiveDataPropertyDescriptor * Improve test to rely on LiveDataPropertyDescriptor objects instead of relying on JSON serialization * Minor fixes after review (cherry picked from commit 65d216e)
surli
added a commit
that referenced
this pull request
Mar 14, 2024
…#2982) * Provide a list of maps of label / values in case of LevelsClass * Provide equals/hashcode/tostring method in LiveDataPropertyDescriptor * Improve test to rely on LiveDataPropertyDescriptor objects instead of relying on JSON serialization * Minor fixes after review (cherry picked from commit 65d216e)
Sereza7
pushed a commit
to Sereza7/xwiki-platform
that referenced
this pull request
Mar 14, 2024
…xwiki#2982) * Provide a list of maps of label / values in case of LevelsClass * Provide equals/hashcode/tostring method in LiveDataPropertyDescriptor * Improve test to rely on LiveDataPropertyDescriptor objects instead of relying on JSON serialization * Minor fixes after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21971
Changes
Description
Clarifications
Screenshots & Video
N/A
Executed Tests
Ran
mvn clean install -Pqualityon module livedata.Expected merging strategy